From: "Michael S. Tsirkin" <mst@redhat•com>
To: linux-kernel@vger•kernel.org
Cc: Andy Whitcroft <apw@canonical•com>, Joe Perches <joe@perches•com>,
Peter Zijlstra <peterz@infradead•org>,
Arnd Bergmann <arnd@arndb•de>,
linux-arch@vger•kernel.org,
Andrew Cooper <andrew.cooper3@citrix•com>,
virtualization@lists•linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu•citrix.com>,
Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
"H. Peter Anvin" <hpa@zytor•com>,
David Miller <davem@davemloft•net>,
linux-ia64@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, sparclinux@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-metag@vger•kernel.org, linux-mips@linux-mips•org,
x86@kernel•org, user-mode-linux-devel@lists•sourceforge.net,
adi-buildroot-devel@lists•sourceforge.net,
linux-sh@vger•kernel.org, linux-xtensa@linux-xtensa•org,
xen-devel@lists•xenproject.org, Ingo Molnar <mingo@kernel•org>,
Tony Lindgren <tony@atomide•com>,
Andrey Konovalov <andreyknvl@google•com>,
Russell King - ARM Linux <linux@arm•linux.org.uk>
Subject: [PATCH v3 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 21:30:49 +0200 [thread overview]
Message-ID: <1452454200-8844-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452454200-8844-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm•linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat•com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1c01b7d..15cfca4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5143,6 +5143,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_(?:$smp_barrier_stems)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b(?:$underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+(?:$underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
next prev parent reply other threads:[~2016-01-10 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 19:30 [PATCH v3 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-10 19:30 ` [PATCH v3 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-10 19:30 ` Michael S. Tsirkin [this message]
2016-01-10 19:31 ` [PATCH v3 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-10 22:13 ` Julian Calaby
2016-01-10 22:52 ` Joe Perches
2016-01-11 10:35 ` Michael S. Tsirkin
2016-01-11 10:40 ` Julian Calaby
2016-01-11 10:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452454200-8844-3-git-send-email-mst@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=andrew.cooper3@citrix$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=apw@canonical$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=mingo@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefano.stabellini@eu$(echo .)citrix.com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox