From: Joe Perches <joe@perches•com>
To: Julian Calaby <julian.calaby@gmail•com>,
"Michael S. Tsirkin" <mst@redhat•com>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Andy Whitcroft <apw@canonical•com>,
Peter Zijlstra <peterz@infradead•org>,
Arnd Bergmann <arnd@arndb•de>,
linux-arch@vger•kernel.org,
Andrew Cooper <andrew.cooper3@citrix•com>,
virtualization@lists•linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu•citrix.com>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@elte•hu>, "H. Peter Anvin" <hpa@zytor•com>,
David Miller <davem@davemloft•net>,
linux-ia64@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org,
sparclinux <sparclinux@vger•kernel.org>,
"Mailing List, Arm" <linux-arm-kernel@lists•infradead.org>,
linux-metag@vger•kernel.org, linux-mips@linux-mips•org,
x86@kernel•org, user-mode-linux-devel@lists•sourceforge.net,
adi-buildroot-devel@lists•sourceforge.net,
linux-sh@vger•kernel.org, linux-xtensa@linux-xtensa•org,
xen-devel@lists•xenproject.org, Ingo Molnar <mingo@kernel•org>,
Tony Lindgren <tony@atomide•com>,
Andrey Konovalov <andreyknvl@google•com>,
Russell King - ARM Linux <linux@arm•linux.org.uk>
Subject: Re: [PATCH v3 3/3] checkpatch: add virt barriers
Date: Sun, 10 Jan 2016 14:52:16 -0800 [thread overview]
Message-ID: <1452466336.7773.46.camel@perches.com> (raw)
In-Reply-To: <CAGRGNgXQANbKD=VA0Qx4Wp1+MpZUVV7by8RrKxF9o=qu=vUQqA@mail.gmail.com>
On Mon, 2016-01-11 at 09:13 +1100, Julian Calaby wrote:
> On Mon, Jan 11, 2016 at 6:31 AM, Michael S. Tsirkin <mst@redhat•com> wrote:
> > Add virt_ barriers to list of barriers to check for
> > presence of a comment.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > @@ -5133,7 +5133,8 @@ sub process {
> > }x;
> > my $all_barriers = qr{
> > $barriers|
> > - smp_(?:$smp_barrier_stems)
> > + smp_(?:$smp_barrier_stems)|
> > + virt_(?:$smp_barrier_stems)
>
> Sorry I'm late to the party here, but would it make sense to write this as:
>
> (?:smp|virt)_(?:$smp_barrier_stems)
Yes. Perhaps the name might be better as barrier_stems.
Also, ideally this would be longest match first or use \b
after the matches so that $all_barriers could work
successfully without a following \s*\(
my $all_barriers = qr{
(?:smp|virt)_(?:barrier_stems)|
$barriers)
}x;
or maybe add separate $smp_barriers and $virt_barriers
<shrug> it doesn't matter much in any case
next prev parent reply other threads:[~2016-01-10 22:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 19:30 [PATCH v3 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-10 19:30 ` [PATCH v3 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-10 19:30 ` [PATCH v3 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-10 19:31 ` [PATCH v3 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-10 22:13 ` Julian Calaby
2016-01-10 22:52 ` Joe Perches [this message]
2016-01-11 10:35 ` Michael S. Tsirkin
2016-01-11 10:40 ` Julian Calaby
2016-01-11 10:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452466336.7773.46.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=andrew.cooper3@citrix$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=apw@canonical$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=julian.calaby@gmail$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=mingo@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefano.stabellini@eu$(echo .)citrix.com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox