From: Michael Ellerman <mpe@ellerman•id.au>
To: "Guilherme G. Piccoli" <gpiccoli@linux•vnet.ibm.com>
Cc: paulus@samba•org, linuxppc-dev@lists•ozlabs.org,
gwshan@linux•vnet.ibm.com
Subject: Re: [PATCH] powerpc/eeh: Validate arch in eeh_add_device_early()
Date: Fri, 15 Jan 2016 10:37:13 +1100 [thread overview]
Message-ID: <1452814633.19265.1.camel@ellerman.id.au> (raw)
In-Reply-To: <5697FE17.4070605@linux.vnet.ibm.com>
On Thu, 2016-01-14 at 17:59 -0200, Guilherme G. Piccoli wrote:
> On 01/13/2016 07:25 PM, Michael Ellerman wrote:
> > But for example what happens if the user boots with eeh=off on the command
> > line, and then hotplugs a device. It looks like because you're not using
> > eeh_enabled() you will incorrectly initialise EEH anyway?
>
> Thanks very much for this catch Michael! I didn't think in this
> possibility; I just tested and it fails with the kernel oops.
OK, that's a pity.
> So, since my patch does not cover this case, I think would be more
> interesting "unlink" the DDW mechanism from the EEH. It seems easy, I'll
> try to send you a patch soon.
>
> Do you think it is a good approach?
It sounds good, but I don't know off hand whether it will work. See how it goes
and send us the patch.
cheers
next prev parent reply other threads:[~2016-01-14 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 3:08 [PATCH] powerpc/eeh: Validate arch in eeh_add_device_early() Guilherme G. Piccoli
2016-01-13 6:04 ` Benjamin Herrenschmidt
2016-01-13 11:56 ` Guilherme G. Piccoli
2016-01-13 10:38 ` Michael Ellerman
2016-01-13 12:08 ` Guilherme G. Piccoli
2016-01-13 21:25 ` Michael Ellerman
2016-01-14 19:59 ` Guilherme G. Piccoli
2016-01-14 23:37 ` Michael Ellerman [this message]
2016-01-19 20:11 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452814633.19265.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=gpiccoli@linux$(echo .)vnet.ibm.com \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox