From: Michael Ellerman <mpe@ellerman•id.au>
To: Vasant Hegde <hegdevasant@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Cc: Dan Williams <dan.j.williams@intel•com>,
Nathan Fontenot <nfont@linux•vnet.ibm.com>
Subject: Re: [PATCH] powerpc/mm: Allow user space to map rtas_rmo_buf
Date: Fri, 22 Jan 2016 16:29:24 +1100 [thread overview]
Message-ID: <1453440564.21683.8.camel@ellerman.id.au> (raw)
In-Reply-To: <1453392931-20707-1-git-send-email-hegdevasant@linux.vnet.ibm.com>
On Thu, 2016-01-21 at 21:45 +0530, Vasant Hegde wrote:
> With commit 90a545e9 (restrict /dev/mem to idle io memory ranges) mapping
> rtas_rmo_buf from user space is failing. Hence we are not able to make
> RTAS syscall.
>
> This patch calls page_is_rtas_user_buf before calling iomem_is_exclusive
> in devmem_is_allowed(). This will allow user space to map rtas_rmo_buf
> and we are able to make RTAS syscall.
Thanks for the patch.
I'll put it in my fixes branch for next week.
Having said that, why the <expletive deleted> is librtas mapping /dev/mem in
the first place? Unless there is a very good reason, and probably even if there
is, we should fix that to use a sane API.
cheers
next prev parent reply other threads:[~2016-01-22 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 16:15 [PATCH] powerpc/mm: Allow user space to map rtas_rmo_buf Vasant Hegde
2016-01-21 16:32 ` Dan Williams
2016-01-22 5:29 ` Michael Ellerman [this message]
2016-01-22 6:28 ` Vasant Hegde
2016-01-22 8:35 ` Michael Ellerman
2016-01-22 10:41 ` Denis Kirjanov
2016-01-25 18:42 ` Nathan Fontenot
2016-01-25 18:42 ` Nathan Fontenot
2016-01-29 1:58 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453440564.21683.8.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=dan.j.williams@intel$(echo .)com \
--cc=hegdevasant@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nfont@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox