Subject: Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

From: Scott Wood <[email-masked]>
Date: Mon, 01 Feb 2016 16:26:51 -0600

On Mon, 2016-02-01 at 16:16 +0530, Raghav Dogra wrote:
>  /*
>   * IFC Controller Registers
>   */
> -struct fsl_ifc_regs {
> +struct fsl_ifc_fcm {
>  	__be32 ifc_rev;
>  	u32 res1[0x2];
>  	struct {

This struct is not specific to fcm (i.e. nand).  Please choose a better name,
such as fsl_ifc_global (which would match "gregs").

-Scott