From: Michael Ellerman <mpe@ellerman•id.au>
To: Cyril Bur <cyrilbur@gmail•com>
Cc: Suraj Jitindar Singh <sjitindarsingh@gmail•com>, linuxppc-dev@ozlabs•org
Subject: Re: selftests/powerpc: Remove -flto from common CFLAGS
Date: Tue, 01 Mar 2016 10:35:14 +1100 [thread overview]
Message-ID: <1456788914.21548.2.camel@ellerman.id.au> (raw)
In-Reply-To: <20160301100825.67747147@camb691>
On Tue, 2016-03-01 at 10:08 +1100, Cyril Bur wrote:
> On Mon, 29 Feb 2016 22:10:13 +1100 (AEDT)
> Michael Ellerman <mpe@ellerman•id.au> wrote:
> > On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote:
> > > Both these cases are hard to detect and require manual inspection of
> > > binaries which is unlikely to happen for all tests. Furthermore, LTO
> > > optimisations are not necessary for selftests and correctness is paramount
> > > and as such it is best to disable LTO.
> > >
> > > LTO can be enabled on a per test basis.
> > >
> > > A pseries_le_defconfig kernel on a POWER8 was used to determine that the
> > > same subset of selftests pass and fail with and without -flto in the
> > > common Makefile.
> > >
> > > These tests always fail:
> > > selftests: per_event_excludes [FAIL]
> > > selftests: event_attributes_test [FAIL]
> > > selftests: ebb_vs_cpu_event_test [FAIL]
> > > selftests: cpu_event_vs_ebb_test [FAIL]
> > > selftests: cpu_event_pinned_vs_ebb_test [FAIL]
> >
> > They shouldn't :)
> >
> > Are you running as root? Bare metal or guest?
>
> Interesting. I believe this was run baremetal as root. I'm going to test the
> patch in qemu at root. Is there a list of expected failures in certain
> situations?
Nope.
Most of those require the perf paranoid level to be set, see eg:
tools/testing/selftests/powerpc/pmu/ebb/cpu_event_vs_ebb_test.c: SKIP_IF(require_paranoia_below(1));
cheers
next prev parent reply other threads:[~2016-02-29 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 6:29 [PATCH] selftests/powerpc: Remove -flto from common CFLAGS Suraj Jitindar Singh
2016-02-29 11:10 ` Michael Ellerman
2016-02-29 23:08 ` Cyril Bur
2016-02-29 23:35 ` Michael Ellerman [this message]
2016-03-01 3:11 ` Cyril Bur
2016-03-01 4:46 ` Suraj Jitindar Singh
2016-03-03 10:58 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456788914.21548.2.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=cyrilbur@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sjitindarsingh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox