public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Michael Ellerman <mpe@ellerman•id.au>
To: Miroslav Benes <mbenes@suse•cz>
Cc: Petr Mladek <pmladek@suse•com>,
	linuxppc-dev@ozlabs•org, jeyu@redhat•com,  jkosina@suse•cz,
	linux-kernel@vger•kernel.org, rostedt@goodmis•org,
	 kamalesh@linux•vnet.ibm.com, duwe@lst•de,
	live-patching@vger•kernel.org,  Torsten Duwe <duwe@suse•de>
Subject: Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc
Date: Mon, 07 Mar 2016 14:29:56 +1100	[thread overview]
Message-ID: <1457321396.19197.3.camel@ellerman.id.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1603041026320.31153@pobox.suse.cz>

On Fri, 2016-03-04 at 10:31 +0100, Miroslav Benes wrote:
> On Fri, 4 Mar 2016, Michael Ellerman wrote:
> > On Thu, 2016-03-03 at 17:52 +0100, Petr Mladek wrote:
> > 
> > >     3. Added an error message when including
> > >        powerpc/include/asm/livepatch.h without HAVE_LIVEPATCH
> > 
> > I don't know why we want to do that, I don't see how it is helpful. It doesn't
> > even do what it says:
> > 
> > > +#ifdef CONFIG_LIVEPATCH
> > ...
> > > +#else /* CONFIG_LIVEPATCH */
> > > +#error Include linux/livepatch.h, not asm/livepatch.h
> > > +#endif /* CONFIG_LIVEPATCH */
> > 
> > If I turn on CONFIG_LIVEPATCH then I can quite happily include asm/livepatch.h
> > and not get an error. So the check doesn't do what the message suggests.
> 
> Well, yes. I looked into the archives to find if there was a reason to 
> even introduce it. It was not. It came up during a review process of the 
> livepatching patch set somehow and we left it there. I only changed the 
> error message to the mentioned one because we deemed it was better.

Thanks for looking into it.

> > And on x86 & s390 it does:
> > 
> >   #else
> >   #error Live patching support is disabled; check CONFIG_LIVEPATCH
> >   #endif
> 
> This is the old message. See 383bf44d1a8b ("livepatch: change the error 
> message in asm/livepatch.h header files").
> 
> Anyway, it really does not mean much. I'll send a patch for s390 and x86 
> to remove it completely in a minute.

Thanks. I know it's not a big deal, but the kernel is complicated enough
without extra code we don't really need :)

cheers

next prev parent reply	other threads:[~2016-03-07  3:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 16:52 [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc Petr Mladek
2016-03-03 20:43 ` Balbir Singh
2016-03-04  6:08 ` Kamalesh Babulal
2016-03-04  7:58 ` Michael Ellerman
2016-03-04  9:31   ` Miroslav Benes
2016-03-07  3:29     ` Michael Ellerman [this message]
2016-03-04  8:06 ` How to merge? (was Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc) Michael Ellerman
2016-03-04  8:56   ` Jiri Kosina
2016-03-07 10:06     ` Michael Ellerman
2016-03-07 22:52       ` Jiri Kosina
2016-03-07 23:20         ` Michael Ellerman
2016-03-08  1:53           ` Steven Rostedt
2016-03-07 23:22         ` Josh Poimboeuf
2016-03-04 12:42 ` [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc Torsten Duwe
2016-03-04 13:01   ` Petr Mladek
2016-03-04 18:16     ` Torsten Duwe
2016-03-04 19:22       ` Torsten Duwe
2016-03-08 11:14         ` Torsten Duwe
2016-03-06 23:55   ` Balbir Singh
2016-03-04 21:56 ` Josh Poimboeuf
2016-03-08 21:42 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457321396.19197.3.camel@ellerman.id.au \
    --to=mpe@ellerman$(echo .)id.au \
    --cc=duwe@lst$(echo .)de \
    --cc=duwe@suse$(echo .)de \
    --cc=jeyu@redhat$(echo .)com \
    --cc=jkosina@suse$(echo .)cz \
    --cc=kamalesh@linux$(echo .)vnet.ibm.com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=live-patching@vger$(echo .)kernel.org \
    --cc=mbenes@suse$(echo .)cz \
    --cc=pmladek@suse$(echo .)com \
    --cc=rostedt@goodmis$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox