Subject: Re: [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback

From: Russell Currey <[email-masked]>
Date: Tue, 15 Mar 2016 16:15:19 +1100

On Tue, 2016-03-15 at 14:56 +1100, Andrew Donnellan wrote:
> On 15/03/16 14:26, Russell Currey wrote:
> > 
> > The HMI code knows about three types of errors: CORE, NX and UNKNOWN.
> > If OPAL were to add a new type, it would not be handled at all since
> > there is no fallback case.  Instead of explicitly checking for UNKNOWN,
> > treat any checkstop type without a handler as unknown.
> > 
> > Signed-off-by: Russell Currey <[email-masked]>
> Indeed it looks like there isn't a fallback case.
> 
> Would it be useful to print xstop_type in the unknown case?

I don't think so - if there's a new checkstop type, specific handling for
it should be implemented in the kernel, and if you're getting unknown
checkstops that are bringing down your machine you should be looking at the
OPAL firmware log anyway, which would contain details if there was
something "new".

> 
> Reviewed-by: Andrew Donnellan <[email-masked]>
>