Subject: Re: [PATCH 2/3] powerpc/eeh: Restore config from edev in eeh_pe_reset_and_recover()

From: Russell Currey <[email-masked]>
Date: Fri, 22 Apr 2016 16:37:52 +1000

On Thu, 2016-04-21 at 21:53 +1000, Gavin Shan wrote:
> The function eeh_pe_reset_and_recover() is used to recover EEH
> error when the passthrou device are transferred to guest and
> backwords. The content in the device's config space will be lost

Spelling, as before :)

> on PE reset issued in the middle of the recovery. The function
> saves/restores it before/after the reset. However, config access
> to some adapters like Broadcom BCM5719 at this point will causes
> fended PHB. The config space is always blocked and we save 0xFF's

"fended" should be "fenced"

> that are restored at late point. The memory BARs are totally
> corrupted, causing another EEH error upon access to one of the
> memory BARs.
> 
> This restores the config space from the content saved to the
> EEH device when it's populated, to resolve above issue.
> 
> Fixes: 5cfb20b9 ("powerpc/eeh: Emulate EEH recovery for VFIO devices")
> Cc: [email-masked] #v3.18+
> Signed-off-by: Gavin Shan <[email-masked]>
> ---

Reviewed-by: Russell Currey <[email-masked]>