From: Michael Ellerman <mpe@ellerman•id.au>
To: Shreyas B Prabhu <shreyas@linux•vnet.ibm.com>,
Daniel Lezcano <daniel.lezcano@linaro•org>
Cc: linuxppc-dev@lists•ozlabs.org, paulus@ozlabs•org,
linux-kernel@vger•kernel.org, mikey@neuling•org,
ego@linux•vnet.ibm.com, maddy@linux•vnet.ibm.com,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
linux-pm@vger•kernel.org, Rob Herring <robh+dt@kernel•org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm•com>
Subject: Re: [PATCH v4 09/10] cpuidle/powernv: Add support for POWER ISA v3 idle states
Date: Wed, 01 Jun 2016 13:12:33 +1000 [thread overview]
Message-ID: <1464750753.19731.2.camel@ellerman.id.au> (raw)
In-Reply-To: <201605311351.u4VDn1i7019941@mx0a-001b2d01.pphosted.com>
On Tue, 2016-05-31 at 19:20 +0530, Shreyas B Prabhu wrote:
> On 05/30/2016 07:56 PM, Daniel Lezcano wrote:
> > On 05/24/2016 03:15 PM, Shreyas B. Prabhu wrote:
> > > + psscr_val = kcalloc(dt_idle_states, sizeof(*psscr_val),
> > > + GFP_KERNEL);
> > > + rc = of_property_read_u64_array(power_mgt,
> > > + "ibm,cpu-idle-state-psscr", psscr_val, dt_idle_states);
> >
> > [cc'ed Lorenzo and Rob ]
> >
> > I don't see the documentation for the binding. Wouldn't make sense to
> > add the value per idle state instead of an index based array ?
The binding *should* be documented here AFAIK:
https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/power-mgt.txt
cheers
next prev parent reply other threads:[~2016-06-01 3:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:15 [PATCH v4 00/10] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 01/10] powerpc/powernv: Use PNV_THREAD_WINKLE macro while requesting for winkle Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 02/10] powerpc/kvm: make hypervisor state restore a function Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 03/10] powerpc/powernv: Rename idle_power7.S to idle_power_common.S Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 04/10] powerpc/powernv: Rename reusable idle functions to hardware agnostic names Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 05/10] powerpc/powernv: Make pnv_powersave_common more generic Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 06/10] powerpc/powernv: abstraction for saving SPRs before entering deep idle states Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 07/10] powerpc/powernv: set power_save func after the idle states are initialized Shreyas B. Prabhu
2016-05-24 13:15 ` [PATCH v4 08/10] powerpc/powernv: Add platform support for stop instruction Shreyas B. Prabhu
2016-05-25 5:05 ` Gautham R Shenoy
2016-05-28 0:06 ` Ram Pai
2016-05-30 16:24 ` Shreyas B Prabhu
2016-05-24 13:15 ` [PATCH v4 09/10] cpuidle/powernv: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-30 14:26 ` Daniel Lezcano
2016-05-31 13:50 ` Shreyas B Prabhu
[not found] ` <201605311351.u4VDn1i7019941@mx0a-001b2d01.pphosted.com>
2016-06-01 3:12 ` Michael Ellerman [this message]
2016-05-24 13:15 ` [PATCH v4 10/10] powerpc/powernv: Use deepest stop state when cpu is offlined Shreyas B. Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464750753.19731.2.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Lorenzo.Pieralisi@arm$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=ego@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)vnet.ibm.com \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@ozlabs$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=shreyas@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox