From: Michael Ellerman <mpe@ellerman•id.au>
To: Scott Wood <oss@buserror•net>, linuxppc-dev@ozlabs•org
Cc: aneesh.kumar@linux•vnet.ibm.com
Subject: Re: [PATCH] powerpc/nohash: Fix build break with 4K pages
Date: Fri, 10 Jun 2016 13:29:39 +1000 [thread overview]
Message-ID: <1465529379.26682.7.camel@ellerman.id.au> (raw)
In-Reply-To: <1465523584.22191.127.camel@buserror.net>
On Thu, 2016-06-09 at 20:53 -0500, Scott Wood wrote:
> On Wed, 2016-06-08 at 23:21 +1000, Michael Ellerman wrote:
> > Commit 74701d5947a6 "powerpc/mm: Rename function to indicate we are
> > allocating fragments" renamed page_table_free() to pte_fragment_free().
> > One occurrence was mistyped as pte_fragment_fre().
> >
> > This only breaks the nohash 4K page build, which is not the default or
> > enabled in any defconfig.
>
> s/4K/64K/
Ugh, yep sorry, the ifdef confused me:
#ifndef CONFIG_PPC_64K_PAGES
...
#else /* if CONFIG_PPC_64K_PAGES */
...
static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
{
pte_fragment_fre((unsigned long *)pte, 1);
}
...
#endif /* CONFIG_PPC_64K_PAGES */
Will update before committing.
cheers
next prev parent reply other threads:[~2016-06-10 3:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 13:21 [PATCH] powerpc/nohash: Fix build break with 4K pages Michael Ellerman
2016-06-08 14:49 ` Aneesh Kumar K.V
2016-06-09 0:08 ` Michael Ellerman
2016-06-10 1:53 ` Scott Wood
2016-06-10 3:29 ` Michael Ellerman [this message]
2016-06-14 3:18 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465529379.26682.7.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=oss@buserror$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox