From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: linuxppc dev list <linuxppc-dev@lists•ozlabs.org>
Subject: [RFC/PATCH] powerpc/pci: Don't try to allocate resources that will be reassigned
Date: Wed, 22 Jun 2016 17:24:37 +1000 [thread overview]
Message-ID: <1466580277.4089.25.camel@kernel.crashing.org> (raw)
When we know we will reassign all resources, trying (and failing)
to allocate them initially is fairly pointless and leads to a lot
of scary messages in the kernel log
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
--
This one probably needs testing on a few platforms but I think it's
correct ;-)
---
arch/powerpc/kernel/pci-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index e723a32..2a67b16 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -1360,9 +1360,9 @@ void __init pcibios_resource_survey(void)
struct pci_bus *b;
/* Allocate and assign resources */
+ list_for_each_entry(b, &pci_root_buses, node)
+ pcibios_allocate_bus_resources(b);
if (!pci_has_flag(PCI_REASSIGN_ALL_RSRC)) {
- list_for_each_entry(b, &pci_root_buses, node)
- pcibios_allocate_bus_resources(b);
pcibios_allocate_resources(0);
pcibios_allocate_resources(1);
}
next reply other threads:[~2016-06-22 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 7:24 Benjamin Herrenschmidt [this message]
2016-06-24 11:33 ` [RFC/PATCH] powerpc/pci: Don't try to allocate resources that will be reassigned Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466580277.4089.25.camel@kernel.crashing.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox