Subject: Re: [PATCH 06/38] powerpc: Move 64-bit feature fixup earlier

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 28 Jun 2016 21:14:29 +1000

On Tue, 2016-06-28 at 16:35 +0530, Aneesh Kumar K.V wrote:
> Why not move it immediately after we finish all the device tress
> scan.

Do you need it in early_init_mmu ? The important thing is to have it
done before we *turn on* the MMU but yeah, there's no big deal
moving it even further up I think..

> ie,
>         early_init_devtree(__va(dt_ptr));
> 
>         epapr_paravirt_early_init();
> 
>   +      apply_feature_fixups();
>         /* Now we know the logical id of our boot cpu, setup the
> paca. */
>         setup_paca(&paca[boot_cpuid]);
>         fixup_boot_paca();
> 
> Also with a comment explaining why we can't move it further up ?

Yup, adding some comments about the why things are done in that order
would be good, I'll improve that

Cheers,
Ben.