From: Rik van Riel <riel@redhat•com>
To: Kees Cook <keescook@chromium•org>, linux-kernel@vger•kernel.org
Cc: Casey Schaufler <casey@schaufler-ca•com>,
PaX Team <pageexec@freemail•hu>,
Brad Spengler <spender@grsecurity•net>,
Russell King <linux@armlinux•org.uk>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Michael Ellerman <mpe@ellerman•id.au>,
Tony Luck <tony.luck@intel•com>,
Fenghua Yu <fenghua.yu@intel•com>,
"David S. Miller" <davem@davemloft•net>,
x86@kernel•org, Christoph Lameter <cl@linux•com>,
Pekka Enberg <penberg@kernel•org>,
David Rientjes <rientjes@google•com>,
Joonsoo Kim <iamjoonsoo.kim@lge•com>,
Andrew Morton <akpm@linux-foundation•org>,
Andy Lutomirski <luto@kernel•org>, Borislav Petkov <bp@suse•de>,
Mathias Krause <minipli@googlemail•com>, Jan Kara <jack@suse•cz>,
Vitaly Wool <vitalywool@gmail•com>,
Andrea Arcangeli <aarcange@redhat•com>,
Dmitry Vyukov <dvyukov@google•com>,
Laura Abbott <labbott@fedoraproject•org>,
linux-arm-kernel@lists•infradead.org, linux-ia64@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, sparclinux@vger•kernel.org,
linux-arch@vger•kernel.org, linux-mm@kvack•org,
kernel-hardening@lists•openwall.com
Subject: Re: [PATCH 1/9] mm: Hardened usercopy
Date: Thu, 07 Jul 2016 12:35:17 -0400 [thread overview]
Message-ID: <1467909317.13253.17.camel@redhat.com> (raw)
In-Reply-To: <1467843928-29351-2-git-send-email-keescook@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
On Wed, 2016-07-06 at 15:25 -0700, Kees Cook wrote:
>
> + /* Allow kernel rodata region (if not marked as Reserved).
> */
> + if (ptr >= (const void *)__start_rodata &&
> + end <= (const void *)__end_rodata)
> + return NULL;
>
One comment here.
__check_object_size gets "to_user" as an argument.
It may make sense to pass that to check_heap_object, and
only allow copy_to_user from rodata, never copy_from_user,
since that section should be read only.
> +void __check_object_size(const void *ptr, unsigned long n, bool
> to_user)
> +{
>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-07 16:35 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 22:25 [PATCH 0/9] mm: Hardened usercopy Kees Cook
2016-07-06 22:25 ` [PATCH 1/9] " Kees Cook
2016-07-07 5:37 ` Baruch Siach
2016-07-07 17:25 ` Kees Cook
2016-07-07 18:35 ` Baruch Siach
2016-07-07 7:42 ` Thomas Gleixner
2016-07-07 17:29 ` Kees Cook
2016-07-07 19:34 ` Thomas Gleixner
2016-07-07 8:01 ` Arnd Bergmann
2016-07-07 17:37 ` Kees Cook
2016-07-08 5:34 ` Michael Ellerman
2016-07-08 9:22 ` Arnd Bergmann
2016-07-07 16:19 ` Rik van Riel
2016-07-07 16:35 ` Rik van Riel [this message]
2016-07-07 17:41 ` Kees Cook
2016-07-06 22:25 ` [PATCH 2/9] x86/uaccess: Enable hardened usercopy Kees Cook
2016-07-06 22:25 ` [PATCH 3/9] ARM: uaccess: " Kees Cook
2016-07-06 22:25 ` [PATCH 4/9] arm64/uaccess: " Kees Cook
2016-07-07 10:07 ` Mark Rutland
2016-07-07 17:19 ` Kees Cook
2016-07-06 22:25 ` [PATCH 5/9] ia64/uaccess: " Kees Cook
2016-07-06 22:25 ` [PATCH 6/9] powerpc/uaccess: " Kees Cook
2016-07-06 22:25 ` [PATCH 7/9] sparc/uaccess: " Kees Cook
2016-07-06 22:25 ` [PATCH 8/9] mm: SLAB hardened usercopy support Kees Cook
2016-07-06 22:25 ` [PATCH 9/9] mm: SLUB " Kees Cook
2016-07-07 4:35 ` Michael Ellerman
[not found] ` <577ddc18.d351190a.1fa54.ffffbe79SMTPIN_ADDED_BROKEN@mx.google.com>
2016-07-07 18:56 ` [kernel-hardening] " Kees Cook
2016-07-08 10:19 ` Michael Ellerman
2016-07-08 13:45 ` Christoph Lameter
2016-07-08 16:07 ` Kees Cook
2016-07-08 16:20 ` Christoph Lameter
2016-07-08 17:41 ` Kees Cook
2016-07-08 20:48 ` Kees Cook
2016-07-09 5:58 ` Michael Ellerman
2016-07-09 6:07 ` Michael Ellerman
[not found] ` <57809299.84b3370a.5390c.ffff9e58SMTPIN_ADDED_BROKEN@mx.google.com>
2016-07-09 6:17 ` Valdis.Kletnieks
2016-07-09 17:07 ` Kees Cook
2016-07-11 6:08 ` Joonsoo Kim
2016-07-07 7:30 ` [PATCH 0/9] mm: Hardened usercopy Christian Borntraeger
2016-07-07 17:27 ` Kees Cook
2016-07-08 8:46 ` Ingo Molnar
2016-07-08 16:19 ` Linus Torvalds
2016-07-08 18:23 ` Ingo Molnar
2016-07-09 2:22 ` Laura Abbott
2016-07-09 2:44 ` Rik van Riel
2016-07-09 7:55 ` Ingo Molnar
2016-07-09 8:25 ` Ard Biesheuvel
2016-07-09 12:58 ` Laura Abbott
2016-07-09 17:03 ` Kees Cook
2016-07-09 17:01 ` Kees Cook
2016-07-09 21:27 ` Andy Lutomirski
2016-07-09 23:16 ` PaX Team
2016-07-10 9:16 ` Ingo Molnar
2016-07-10 12:03 ` PaX Team
2016-07-10 12:38 ` Andy Lutomirski
2016-07-11 18:40 ` Kees Cook
2016-07-11 18:34 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467909317.13253.17.camel@redhat.com \
--to=riel@redhat$(echo .)com \
--cc=aarcange@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bp@suse$(echo .)de \
--cc=casey@schaufler-ca$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cl@linux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dvyukov@google$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=jack@suse$(echo .)cz \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=labbott@fedoraproject$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=minipli@googlemail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=pageexec@freemail$(echo .)hu \
--cc=penberg@kernel$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=spender@grsecurity$(echo .)net \
--cc=tony.luck@intel$(echo .)com \
--cc=vitalywool@gmail$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox