* [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
[not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
@ 2016-08-04 22:58 ` York Sun
2016-08-04 23:36 ` Andrew Donnellan
2016-08-05 3:43 ` Michael Ellerman
0 siblings, 2 replies; 13+ messages in thread
From: York Sun @ 2016-08-04 22:58 UTC (permalink / raw)
To: linux-edac
Cc: morbidrsa, oss, stuart.yoder, bp, York Sun,
Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Kevin Hao, Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev, linux-kernel
Two symbols are missing if mpc85xx_edac driver is compiled as module.
Signed-off-by: York Sun <york.sun@nxp•com>
---
Change log
v3: Change subject tag
v2: no change
arch/powerpc/kernel/pci-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index 0f7a60f..86bc484 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -226,6 +226,7 @@ struct pci_controller* pci_find_hose_for_OF_device(struct device_node* node)
}
return NULL;
}
+EXPORT_SYMBOL(pci_find_hose_for_OF_device);
/*
* Reads the interrupt pin to determine if interrupt is use by card.
@@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
{
return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
}
+EXPORT_SYMBOL(early_find_capability);
struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
@ 2016-08-04 23:36 ` Andrew Donnellan
2016-08-04 23:39 ` york sun
2016-08-05 3:43 ` Michael Ellerman
1 sibling, 1 reply; 13+ messages in thread
From: Andrew Donnellan @ 2016-08-04 23:36 UTC (permalink / raw)
To: York Sun, linux-edac
Cc: morbidrsa, oss, stuart.yoder, bp, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Kevin Hao, Yinghai Lu,
Bjorn Helgaas, linuxppc-dev, linux-kernel
On 05/08/16 08:58, York Sun wrote:
> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>
> Signed-off-by: York Sun <york.sun@nxp•com>
Good catch! One comment below.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
> /*
> * Reads the interrupt pin to determine if interrupt is use by card.
> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
> {
> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
> }
> +EXPORT_SYMBOL(early_find_capability);
It'd be nicer for this to be renamed as "pci_early_find_capability" or
something like that with a "namespace", I think.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1•ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-04 23:36 ` Andrew Donnellan
@ 2016-08-04 23:39 ` york sun
2016-08-05 6:58 ` Borislav Petkov
0 siblings, 1 reply; 13+ messages in thread
From: york sun @ 2016-08-04 23:39 UTC (permalink / raw)
To: Andrew Donnellan, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, oss@buserror•net, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Kevin Hao, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On 08/04/2016 04:36 PM, Andrew Donnellan wrote:=0A=
> On 05/08/16 08:58, York Sun wrote:=0A=
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.=0A=
>>=0A=
>> Signed-off-by: York Sun <york.sun@nxp•com>=0A=
>=0A=
> Good catch! One comment below.=0A=
>=0A=
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>=0A=
>=0A=
>> /*=0A=
>> * Reads the interrupt pin to determine if interrupt is use by card.=0A=
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *h=
ose, int bus, int devfn,=0A=
>> {=0A=
>> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);=
=0A=
>> }=0A=
>> +EXPORT_SYMBOL(early_find_capability);=0A=
>=0A=
> It'd be nicer for this to be renamed as "pci_early_find_capability" or=0A=
> something like that with a "namespace", I think.=0A=
>=0A=
=0A=
I will rename it if I respin this patch for any reason. Otherwise, I =0A=
will send out another patch to rename it after merging.=0A=
=0A=
York=0A=
=0A=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36 ` Andrew Donnellan
@ 2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
2016-08-05 20:29 ` york sun
1 sibling, 2 replies; 13+ messages in thread
From: Michael Ellerman @ 2016-08-05 3:43 UTC (permalink / raw)
To: York Sun, linux-edac
Cc: morbidrsa, oss, stuart.yoder, bp, York Sun,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas, linuxppc-dev,
linux-kernel
York Sun <york.sun@nxp•com> writes:
> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>
> Signed-off-by: York Sun <york.sun@nxp•com>
>
> ---
> Change log
> v3: Change subject tag
> v2: no change
>
> arch/powerpc/kernel/pci-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
> index 0f7a60f..86bc484 100644
> --- a/arch/powerpc/kernel/pci-common.c
> +++ b/arch/powerpc/kernel/pci-common.c
> @@ -226,6 +226,7 @@ struct pci_controller* pci_find_hose_for_OF_device(struct device_node* node)
> }
> return NULL;
> }
> +EXPORT_SYMBOL(pci_find_hose_for_OF_device);
>
> /*
> * Reads the interrupt pin to determine if interrupt is use by card.
> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
> {
> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
> }
> +EXPORT_SYMBOL(early_find_capability);
Does the driver really need to use these routines? They're meant for use
early in boot, before PCI is setup.
AFAICS this is just a regular driver, so when it's probed the PCI
devices should have already been scanned. In which case pci_get_device()
could work couldn't it? (I see other edac drivers doing that).
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 3:43 ` Michael Ellerman
@ 2016-08-05 4:26 ` york sun
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 20:29 ` york sun
1 sibling, 1 reply; 13+ messages in thread
From: york sun @ 2016-08-05 4:26 UTC (permalink / raw)
To: Michael Ellerman, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, oss@buserror•net, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On 08/04/2016 08:43 PM, Michael Ellerman wrote:=0A=
> York Sun <york.sun@nxp•com> writes:=0A=
>=0A=
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.=0A=
>>=0A=
>> Signed-off-by: York Sun <york.sun@nxp•com>=0A=
>>=0A=
>> ---=0A=
>> Change log=0A=
>> v3: Change subject tag=0A=
>> v2: no change=0A=
>>=0A=
>> arch/powerpc/kernel/pci-common.c | 2 ++=0A=
>> 1 file changed, 2 insertions(+)=0A=
>>=0A=
>> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-=
common.c=0A=
>> index 0f7a60f..86bc484 100644=0A=
>> --- a/arch/powerpc/kernel/pci-common.c=0A=
>> +++ b/arch/powerpc/kernel/pci-common.c=0A=
>> @@ -226,6 +226,7 @@ struct pci_controller* pci_find_hose_for_OF_device(s=
truct device_node* node)=0A=
>> }=0A=
>> return NULL;=0A=
>> }=0A=
>> +EXPORT_SYMBOL(pci_find_hose_for_OF_device);=0A=
>>=0A=
>> /*=0A=
>> * Reads the interrupt pin to determine if interrupt is use by card.=0A=
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *h=
ose, int bus, int devfn,=0A=
>> {=0A=
>> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);=
=0A=
>> }=0A=
>> +EXPORT_SYMBOL(early_find_capability);=0A=
>=0A=
> Does the driver really need to use these routines? They're meant for use=
=0A=
> early in boot, before PCI is setup.=0A=
>=0A=
> AFAICS this is just a regular driver, so when it's probed the PCI=0A=
> devices should have already been scanned. In which case pci_get_device()=
=0A=
> could work couldn't it? (I see other edac drivers doing that).=0A=
>=0A=
=0A=
I don't have deep knowledge of this driver. What I am trying is to =0A=
separate the common DDR part and share it with ARM platforms. Along the =0A=
way, I found the compiling error if build a module. If exposing these =0A=
functions becomes a concern, I can live without it.=0A=
=0A=
York=0A=
=0A=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-04 23:39 ` york sun
@ 2016-08-05 6:58 ` Borislav Petkov
0 siblings, 0 replies; 13+ messages in thread
From: Borislav Petkov @ 2016-08-05 6:58 UTC (permalink / raw)
To: york sun
Cc: Andrew Donnellan, linux-edac@vger•kernel.org, morbidrsa@gmail•com,
oss@buserror•net, Stuart Yoder, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Kevin Hao, Yinghai Lu,
Bjorn Helgaas, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
On Thu, Aug 04, 2016 at 11:39:14PM +0000, york sun wrote:
> I will rename it if I respin this patch for any reason. Otherwise, I
> will send out another patch to rename it after merging.
Feel free to send an updated one as a reply to this thread.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 4:26 ` york sun
@ 2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
0 siblings, 2 replies; 13+ messages in thread
From: Borislav Petkov @ 2016-08-05 7:01 UTC (permalink / raw)
To: york sun, Johannes Thumshirn
Cc: Michael Ellerman, linux-edac@vger•kernel.org, morbidrsa@gmail•com,
oss@buserror•net, Stuart Yoder, Benjamin Herrenschmidt,
Paul Mackerras, Kevin Hao, Andrew Donnellan, Yinghai Lu,
Bjorn Helgaas, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
On Fri, Aug 05, 2016 at 04:26:26AM +0000, york sun wrote:
> I don't have deep knowledge of this driver. What I am trying is to
> separate the common DDR part and share it with ARM platforms. Along the
> way, I found the compiling error if build a module. If exposing these
> functions becomes a concern, I can live without it.
Perhaps you or Johannes could fix this properly to use pci_get_device()
as the rest of the EDAC drivers do, instead of exporting core PCI
functions...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 7:01 ` Borislav Petkov
@ 2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
1 sibling, 0 replies; 13+ messages in thread
From: Johannes Thumshirn @ 2016-08-05 7:14 UTC (permalink / raw)
To: Borislav Petkov
Cc: york sun, Michael Ellerman, linux-edac@vger•kernel.org,
morbidrsa@gmail•com, oss@buserror•net, Stuart Yoder,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On Fri, Aug 05, 2016 at 09:01:26AM +0200, Borislav Petkov wrote:
> On Fri, Aug 05, 2016 at 04:26:26AM +0000, york sun wrote:
> > I don't have deep knowledge of this driver. What I am trying is to
> > separate the common DDR part and share it with ARM platforms. Along the
> > way, I found the compiling error if build a module. If exposing these
> > functions becomes a concern, I can live without it.
>
> Perhaps you or Johannes could fix this properly to use pci_get_device()
> as the rest of the EDAC drivers do, instead of exporting core PCI
> functions...
I can give it a shot, but I don't have too much spare time atm and no hardware
to test, so it'll have a strong RFC smell attached to it.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse•de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
@ 2016-08-05 20:29 ` york sun
2016-08-05 21:09 ` Scott Wood
1 sibling, 1 reply; 13+ messages in thread
From: york sun @ 2016-08-05 20:29 UTC (permalink / raw)
To: Michael Ellerman, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, oss@buserror•net, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On 08/04/2016 08:43 PM, Michael Ellerman wrote:=0A=
> York Sun <york.sun@nxp•com> writes:=0A=
>=0A=
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.=0A=
>>=0A=
>> Signed-off-by: York Sun <york.sun@nxp•com>=0A=
>>=0A=
>> ---=0A=
>> Change log=0A=
>> v3: Change subject tag=0A=
>> v2: no change=0A=
>>=0A=
>> arch/powerpc/kernel/pci-common.c | 2 ++=0A=
>> 1 file changed, 2 insertions(+)=0A=
>>=0A=
>> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-=
common.c=0A=
>> index 0f7a60f..86bc484 100644=0A=
>> --- a/arch/powerpc/kernel/pci-common.c=0A=
>> +++ b/arch/powerpc/kernel/pci-common.c=0A=
>> @@ -226,6 +226,7 @@ struct pci_controller* pci_find_hose_for_OF_device(s=
truct device_node* node)=0A=
>> }=0A=
>> return NULL;=0A=
>> }=0A=
>> +EXPORT_SYMBOL(pci_find_hose_for_OF_device);=0A=
>>=0A=
>> /*=0A=
>> * Reads the interrupt pin to determine if interrupt is use by card.=0A=
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *h=
ose, int bus, int devfn,=0A=
>> {=0A=
>> return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);=
=0A=
>> }=0A=
>> +EXPORT_SYMBOL(early_find_capability);=0A=
>=0A=
> Does the driver really need to use these routines? They're meant for use=
=0A=
> early in boot, before PCI is setup.=0A=
>=0A=
> AFAICS this is just a regular driver, so when it's probed the PCI=0A=
> devices should have already been scanned. In which case pci_get_device()=
=0A=
> could work couldn't it? (I see other edac drivers doing that).=0A=
=0A=
I am trying to fix this but need some help. We are dealing with PCIe =0A=
controller here. Does it have a bus number assigned at this point? If =0A=
yes, how can I find it? I seem not able to find out where the =0A=
platform_data is filled as well. Can someone kindly point it out to me?=0A=
=0A=
York=0A=
=0A=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 20:29 ` york sun
@ 2016-08-05 21:09 ` Scott Wood
2016-08-05 21:20 ` york sun
0 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2016-08-05 21:09 UTC (permalink / raw)
To: york sun, Michael Ellerman, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On Fri, 2016-08-05 at 20:29 +0000, york sun wrote:
> On 08/04/2016 08:43 PM, Michael Ellerman wrote:
> >
> > Does the driver really need to use these routines? They're meant for use
> > early in boot, before PCI is setup.
> >
> > AFAICS this is just a regular driver, so when it's probed the PCI
> > devices should have already been scanned. In which case pci_get_device()
> > could work couldn't it? (I see other edac drivers doing that).
> I am trying to fix this but need some help. We are dealing with PCIe
> controller here. Does it have a bus number assigned at this point? If
> yes, how can I find it? I seem not able to find out where the
> platform_data is filled as well. Can someone kindly point it out to me?
The platform data comes from add_err_dev() in arch/powerpc/sysdev/fsl_pci.c.
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 21:09 ` Scott Wood
@ 2016-08-05 21:20 ` york sun
2016-08-05 21:57 ` Scott Wood
0 siblings, 1 reply; 13+ messages in thread
From: york sun @ 2016-08-05 21:20 UTC (permalink / raw)
To: Scott Wood, Michael Ellerman, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On 08/05/2016 02:09 PM, Scott Wood wrote:=0A=
> On Fri, 2016-08-05 at 20:29 +0000, york sun wrote:=0A=
>> On 08/04/2016 08:43 PM, Michael Ellerman wrote:=0A=
>>>=0A=
>>> Does the driver really need to use these routines? They're meant for us=
e=0A=
>>> early in boot, before PCI is setup.=0A=
>>>=0A=
>>> AFAICS this is just a regular driver, so when it's probed the PCI=0A=
>>> devices should have already been scanned. In which case pci_get_device(=
)=0A=
>>> could work couldn't it? (I see other edac drivers doing that).=0A=
>> I am trying to fix this but need some help. We are dealing with PCIe=0A=
>> controller here. Does it have a bus number assigned at this point? If=0A=
>> yes, how can I find it? I seem not able to find out where the=0A=
>> platform_data is filled as well. Can someone kindly point it out to me?=
=0A=
>=0A=
>=0A=
> The platform data comes from add_err_dev() in arch/powerpc/sysdev/fsl_pci=
.c.=0A=
>=0A=
=0A=
Thanks, Scott.=0A=
=0A=
When add_err_dev() is called, pci is not scanned, is using =0A=
early_find_capability() justified?=0A=
=0A=
York=0A=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 21:20 ` york sun
@ 2016-08-05 21:57 ` Scott Wood
0 siblings, 0 replies; 13+ messages in thread
From: Scott Wood @ 2016-08-05 21:57 UTC (permalink / raw)
To: york sun, Michael Ellerman, linux-edac@vger•kernel.org
Cc: morbidrsa@gmail•com, Stuart Yoder, bp@alien8•de,
Benjamin Herrenschmidt, Paul Mackerras, Kevin Hao,
Andrew Donnellan, Yinghai Lu, Bjorn Helgaas,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On Fri, 2016-08-05 at 21:20 +0000, york sun wrote:
> On 08/05/2016 02:09 PM, Scott Wood wrote:
> >
> > On Fri, 2016-08-05 at 20:29 +0000, york sun wrote:
> > >
> > > On 08/04/2016 08:43 PM, Michael Ellerman wrote:
> > > >
> > > >
> > > > Does the driver really need to use these routines? They're meant for
> > > > use
> > > > early in boot, before PCI is setup.
> > > >
> > > > AFAICS this is just a regular driver, so when it's probed the PCI
> > > > devices should have already been scanned. In which case
> > > > pci_get_device()
> > > > could work couldn't it? (I see other edac drivers doing that).
> > > I am trying to fix this but need some help. We are dealing with PCIe
> > > controller here. Does it have a bus number assigned at this point? If
> > > yes, how can I find it? I seem not able to find out where the
> > > platform_data is filled as well. Can someone kindly point it out to me?
> >
> > The platform data comes from add_err_dev() in
> > arch/powerpc/sysdev/fsl_pci.c.
> >
> Thanks, Scott.
>
> When add_err_dev() is called, pci is not scanned, is using
> early_find_capability() justified?
The edac driver is registered with a normal device-level initcall. The PCI
scanning appears to happen at the subsys initcall level.
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
@ 2016-08-08 15:47 ` york sun
1 sibling, 0 replies; 13+ messages in thread
From: york sun @ 2016-08-08 15:47 UTC (permalink / raw)
To: Borislav Petkov, Johannes Thumshirn
Cc: Michael Ellerman, linux-edac@vger•kernel.org, morbidrsa@gmail•com,
oss@buserror•net, Stuart Yoder, Benjamin Herrenschmidt,
Paul Mackerras, Kevin Hao, Andrew Donnellan, Yinghai Lu,
Bjorn Helgaas, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
On 08/05/2016 12:01 AM, Borislav Petkov wrote:=0A=
> On Fri, Aug 05, 2016 at 04:26:26AM +0000, york sun wrote:=0A=
>> I don't have deep knowledge of this driver. What I am trying is to=0A=
>> separate the common DDR part and share it with ARM platforms. Along the=
=0A=
>> way, I found the compiling error if build a module. If exposing these=0A=
>> functions becomes a concern, I can live without it.=0A=
>=0A=
> Perhaps you or Johannes could fix this properly to use pci_get_device()=
=0A=
> as the rest of the EDAC drivers do, instead of exporting core PCI=0A=
> functions...=0A=
>=0A=
=0A=
Boris,=0A=
=0A=
I'd like to separate the first two patches from this set. They are not =0A=
really related to the DDR part I am working on. It will take me a while =0A=
to sort out the correct fix.=0A=
=0A=
York=0A=
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-08-08 17:21 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36 ` Andrew Donnellan
2016-08-04 23:39 ` york sun
2016-08-05 6:58 ` Borislav Petkov
2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
2016-08-05 20:29 ` york sun
2016-08-05 21:09 ` Scott Wood
2016-08-05 21:20 ` york sun
2016-08-05 21:57 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox