From: Scott Wood <oss@buserror•net>
To: york sun <york.sun@nxp•com>,
Michael Ellerman <mpe@ellerman•id.au>,
"linux-edac@vger•kernel.org" <linux-edac@vger•kernel.org>
Cc: "morbidrsa@gmail•com" <morbidrsa@gmail•com>,
Stuart Yoder <stuart.yoder@nxp•com>,
"bp@alien8•de" <bp@alien8•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>, Kevin Hao <haokexin@gmail•com>,
Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Yinghai Lu <yinghai@kernel•org>,
Bjorn Helgaas <bhelgaas@google•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
Date: Fri, 05 Aug 2016 16:57:56 -0500 [thread overview]
Message-ID: <1470434276.25630.255.camel@buserror.net> (raw)
In-Reply-To: <AM4PR0401MB1732B0DB22A85A35D9C570679A180@AM4PR0401MB1732.eurprd04.prod.outlook.com>
On Fri, 2016-08-05 at 21:20 +0000, york sun wrote:
> On 08/05/2016 02:09 PM, Scott Wood wrote:
> >
> > On Fri, 2016-08-05 at 20:29 +0000, york sun wrote:
> > >
> > > On 08/04/2016 08:43 PM, Michael Ellerman wrote:
> > > >
> > > >
> > > > Does the driver really need to use these routines? They're meant for
> > > > use
> > > > early in boot, before PCI is setup.
> > > >
> > > > AFAICS this is just a regular driver, so when it's probed the PCI
> > > > devices should have already been scanned. In which case
> > > > pci_get_device()
> > > > could work couldn't it? (I see other edac drivers doing that).
> > > I am trying to fix this but need some help. We are dealing with PCIe
> > > controller here. Does it have a bus number assigned at this point? If
> > > yes, how can I find it? I seem not able to find out where the
> > > platform_data is filled as well. Can someone kindly point it out to me?
> >
> > The platform data comes from add_err_dev() in
> > arch/powerpc/sysdev/fsl_pci.c.
> >
> Thanks, Scott.
>
> When add_err_dev() is called, pci is not scanned, is using
> early_find_capability() justified?
The edac driver is registered with a normal device-level initcall. The PCI
scanning appears to happen at the subsys initcall level.
-Scott
prev parent reply other threads:[~2016-08-05 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36 ` Andrew Donnellan
2016-08-04 23:39 ` york sun
2016-08-05 6:58 ` Borislav Petkov
2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
2016-08-05 20:29 ` york sun
2016-08-05 21:09 ` Scott Wood
2016-08-05 21:20 ` york sun
2016-08-05 21:57 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470434276.25630.255.camel@buserror.net \
--to=oss@buserror$(echo .)net \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=haokexin@gmail$(echo .)com \
--cc=linux-edac@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=morbidrsa@gmail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=stuart.yoder@nxp$(echo .)com \
--cc=yinghai@kernel$(echo .)org \
--cc=york.sun@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox