From: Michael Neuling <mikey@neuling•org>
To: Cyril Bur <cyrilbur@gmail•com>,
linuxppc-dev@lists•ozlabs.org, wei.guo.simon@gmail•com
Cc: anton@samba•org
Subject: Re: [PATCH v3 03/21] powerpc: Add check_if_tm_restore_required() to giveup_all()
Date: Fri, 19 Aug 2016 16:40:15 +1000 [thread overview]
Message-ID: <1471588815.5780.121.camel@neuling.org> (raw)
In-Reply-To: <20160817034323.23053-4-cyrilbur@gmail.com>
On Wed, 2016-08-17 at 13:43 +1000, Cyril Bur wrote:
> giveup_all() causes FPU/VMX/VSX facilitities to be disabled in a
facilities.
> threads MSR. If this thread was transactional this should be recorded
> as reclaiming/recheckpointing code will need to know.
Can you expand on this?=C2=A0=C2=A0It's not clear to me how this relates to=
the code.
Mikey
> Fixes: c208505 ("powerpc: create giveup_all()")
> Signed-off-by: Cyril Bur <cyrilbur@gmail•com>
> ---
> =C2=A0arch/powerpc/kernel/process.c | 1 +
> =C2=A01 file changed, 1 insertion(+)
>=20
> diff --git a/arch/powerpc/kernel/process.c
> b/arch/powerpc/kernel/process.c
> index cdf2d20..82308fd 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -445,6 +445,7 @@ void giveup_all(struct task_struct *tsk)
> =C2=A0 return;
> =C2=A0
> =C2=A0 msr_check_and_set(msr_all_available);
> + check_if_tm_restore_required(tsk);
> =C2=A0
> =C2=A0#ifdef CONFIG_PPC_FPU
> =C2=A0 if (usermsr & MSR_FP)
next prev parent reply other threads:[~2016-08-19 6:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 3:43 [PATCH v3 00/21] Consistent TM structures Cyril Bur
2016-08-17 3:43 ` [PATCH v3 01/21] selftests/powerpc: Compile selftests against headers without AT_HWCAP2 Cyril Bur
2016-08-17 3:43 ` [PATCH v3 02/21] powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use Cyril Bur
2016-08-19 6:33 ` Michael Neuling
2016-08-23 0:57 ` Cyril Bur
2016-08-17 3:43 ` [PATCH v3 03/21] powerpc: Add check_if_tm_restore_required() to giveup_all() Cyril Bur
2016-08-19 6:40 ` Michael Neuling [this message]
2016-08-17 3:43 ` [PATCH v3 04/21] powerpc: Return the new MSR from msr_check_and_set() Cyril Bur
2016-08-17 3:53 ` Cyril Bur
2016-08-19 6:47 ` Michael Neuling
2016-08-17 3:43 ` [PATCH v3 05/21] powerpc: Never giveup a reclaimed thread when enabling kernel {fp, altivec, vsx} Cyril Bur
2016-08-17 3:43 ` [PATCH v3 06/21] powerpc: signals: Stop using current in signal code Cyril Bur
2016-08-17 4:31 ` kbuild test robot
2016-08-17 3:43 ` [PATCH v3 07/21] selftests/powerpc: Check for VSX preservation across userspace preemption Cyril Bur
2016-08-17 3:43 ` [PATCH v3 08/21] selftests/powerpc: Rework FPU stack placement macros and move to header file Cyril Bur
2016-08-17 3:43 ` [PATCH v3 09/21] selftests/powerpc: Move VMX stack frame macros " Cyril Bur
2016-08-17 3:43 ` [PATCH v3 10/21] selftests/powerpc: Introduce GPR asm helper " Cyril Bur
2016-08-17 3:43 ` [PATCH v3 11/21] selftests/powerpc: Add transactional memory defines Cyril Bur
2016-08-17 3:43 ` [PATCH v3 12/21] selftests/powerpc: Allow tests to extend their kill timeout Cyril Bur
2016-08-17 3:43 ` [PATCH v3 13/21] selftests/powerpc: Add TM tcheck helpers in C Cyril Bur
2016-08-17 3:43 ` [PATCH v3 14/21] selftests/powerpc: Check that signals always get delivered Cyril Bur
2016-08-17 3:43 ` [PATCH v3 15/21] selftests/powerpc: Add checks for transactional GPRs in signal contexts Cyril Bur
2016-08-17 3:43 ` [PATCH v3 16/21] selftests/powerpc: Add checks for transactional FPUs " Cyril Bur
2016-08-17 3:43 ` [PATCH v3 17/21] selftests/powerpc: Add checks for transactional VMXs " Cyril Bur
2016-08-17 3:43 ` [PATCH v3 18/21] selftests/powerpc: Add checks for transactional VSXs " Cyril Bur
2016-08-17 3:43 ` [PATCH v3 19/21] powerpc: tm: Always use fp_state and vr_state to store live registers Cyril Bur
2016-08-19 4:04 ` Simon Guo
2016-08-17 3:43 ` [PATCH v3 20/21] powerpc: tm: Rename transct_(*) to ck(\1)_state Cyril Bur
2016-08-17 3:43 ` [PATCH v3 21/21] powerpc: Remove do_load_up_transact_{fpu,altivec} Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471588815.5780.121.camel@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=cyrilbur@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=wei.guo.simon@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox