Subject: Re: [PATCH v3 03/21] powerpc: Add check_if_tm_restore_required() to giveup_all()

From: Michael Neuling <[email-masked]>
Date: Fri, 19 Aug 2016 16:40:15 +1000

On Wed, 2016-08-17 at 13:43 +1000, Cyril Bur wrote:
> giveup_all() causes FPU/VMX/VSX facilitities to be disabled in a

facilities.

> threads MSR. If this thread was transactional this should be recorded
> as reclaiming/recheckpointing code will need to know.

Can you expand on this?  It's not clear to me how this relates to the code.

Mikey

> Fixes: c208505 ("powerpc: create giveup_all()")
> Signed-off-by: Cyril Bur <[email-masked]>
> ---
>  arch/powerpc/kernel/process.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kernel/process.c
> b/arch/powerpc/kernel/process.c
> index cdf2d20..82308fd 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -445,6 +445,7 @@ void giveup_all(struct task_struct *tsk)
>  		return;
>  
>  	msr_check_and_set(msr_all_available);
> +	check_if_tm_restore_required(tsk);
>  
>  #ifdef CONFIG_PPC_FPU
>  	if (usermsr & MSR_FP)