From: Scott Wood <oss@buserror•net>
To: Paul Gortmaker <paul.gortmaker@windriver•com>,
linux-kernel@vger•kernel.org
Cc: Yangbo Lu <yangbo.lu@nxp•com>, Arnd Bergmann <arnd@arndb•de>,
Ulf Hansson <ulf.hansson@linaro•org>,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 3/3] soc: fsl: make guts driver explicitly non-modular
Date: Mon, 14 Nov 2016 23:10:24 -0600 [thread overview]
Message-ID: <1479186624.21746.15.camel@buserror.net> (raw)
In-Reply-To: <20161113190302.18099-4-paul.gortmaker@windriver.com>
On Sun, 2016-11-13 at 14:03 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/soc/fsl/Kconfig:config FSL_GUTS
> drivers/soc/fsl/Kconfig: bool
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since the code was already not using module_init, the init ordering
> remains unchanged with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Scott Wood <oss@buserror•net>
> Cc: Yangbo Lu <yangbo.lu@nxp•com>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: Ulf Hansson <ulf.hansson@linaro•org>
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-arm-kernel@lists•infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Acked-by: Scott Wood <oss@buserror•net>
-Scott
prev parent reply other threads:[~2016-11-15 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 19:02 [PATCH 0/3] soc: avoid module usage in non-modular code Paul Gortmaker
2016-11-13 19:03 ` [PATCH 3/3] soc: fsl: make guts driver explicitly non-modular Paul Gortmaker
2016-11-15 5:10 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479186624.21746.15.camel@buserror.net \
--to=oss@buserror$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=yangbo.lu@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox