From: Alistair Popple <alistair@popple•id.au>
To: Pranith Kumar <bobby.prani@gmail•com>
Cc: open list <linux-kernel@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc: Fix build failure
Date: Tue, 16 Sep 2014 14:12:37 +1000 [thread overview]
Message-ID: <1480446.gFeczbkrbH@mexican> (raw)
In-Reply-To: <1408626271-13519-1-git-send-email-bobby.prani@gmail.com>
Thanks for fixing these!
Acked-by: Alistair Popple <alistair@popple•id.au>
On Thu, 21 Aug 2014 09:04:31 Pranith Kumar wrote:
> Fix the following build failure
>
> drivers/built-in.o: In function `nhi_init':
> nhi.c:(.init.text+0x63390): undefined reference to `ehci_init_driver'
>
> by adding a dependency on USB_EHCI_HCD which supplies the
> ehci_init_driver().
>
> Also we need to depend on USB_OHCI_HCD similarly
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail•com>
> ---
> arch/powerpc/platforms/44x/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig
> b/arch/powerpc/platforms/44x/Kconfig index 4d88f6a..3e7deb2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -216,8 +216,8 @@ config AKEBONO
> select IBM_EMAC_EMAC4
> select IBM_EMAC_RGMII_WOL
> select USB
> - select USB_OHCI_HCD_PLATFORM
> - select USB_EHCI_HCD_PLATFORM
> + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> + select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
> select MMC_SDHCI
> select MMC_SDHCI_PLTFM
> select MMC_SDHCI_OF_476GTR
prev parent reply other threads:[~2014-09-16 4:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 13:04 [PATCH] powerpc: Fix build failure Pranith Kumar
2014-09-16 4:12 ` Alistair Popple [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480446.gFeczbkrbH@mexican \
--to=alistair@popple$(echo .)id.au \
--cc=bobby.prani@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox