From: Benjamin Herrenschmidt <benh@au1•ibm.com>
To: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/64: pseudo-NMI/SMP watchdog
Date: Sat, 10 Dec 2016 08:17:20 +1100 [thread overview]
Message-ID: <1481318240.17253.25.camel@au1.ibm.com> (raw)
In-Reply-To: <20161209155252.31381-1-npiggin@gmail.com>
On Sat, 2016-12-10 at 01:52 +1000, Nicholas Piggin wrote:
> This does not solve the hardlockup problem completely however,
> because
> interrupts can often become hard disabled when soft disabled for long
> periods. And they can be hard disabled for other reasons.
>
> To make up for the lack of a periodic true NMI, this also has an SMP
> hard lockup detector where all CPUs can observe lockups on others.
>
> This still needs a bit more polishing, testing, comments, config
> options, and boot parameters, etc., so it's RFC quality only.
Paulus and I discussed a plan with Balbir to also limit the cases of
hard-disable.
They typically happen as a result of an external interrupt. We could
on P8 and earlier, just fetch the interrupt from the XICS in the
"masked" path and stash it in the PACA. We already have a way to
stash an interrupt there for later processing because KVM sometimes
does it.
That would cause the XICS to elevate the priority effectively masking
subsequent interrupts. We'd have to change the XICS code to use the
same priority for IPIs and externals too though.
For XIVE (P9), we can just poke at the CPU priority register in the TM
area to mask at the PIC level in that case and unmask later.
Cheers,
Ben.
next prev parent reply other threads:[~2016-12-09 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 15:52 [PATCH] powerpc/64: pseudo-NMI/SMP watchdog Nicholas Piggin
2016-12-09 21:17 ` Benjamin Herrenschmidt [this message]
2016-12-10 5:22 ` Balbir Singh
2016-12-10 6:05 ` Nicholas Piggin
2016-12-10 12:24 ` Balbir Singh
2016-12-12 4:09 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481318240.17253.25.camel@au1.ibm.com \
--to=benh@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox