From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>,
Reza Arbab <arbab@linux•vnet.ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Paul Mackerras <paulus@samba•org>
Cc: linuxppc-dev@lists•ozlabs.org,
Balbir Singh <bsingharora@gmail•com>,
Alistair Popple <apopple@au1•ibm.com>
Subject: Re: [PATCH v3 4/5] powerpc/mm: add radix__remove_section_mapping()
Date: Tue, 20 Dec 2016 07:59:22 +1100 [thread overview]
Message-ID: <1482181162.15937.32.camel@kernel.crashing.org> (raw)
In-Reply-To: <87wpewtfl4.fsf@linux.vnet.ibm.com>
On Mon, 2016-12-19 at 15:18 +0530, Aneesh Kumar K.V wrote:
> > + pte = pte_start + pte_index(addr);
> > + for (; addr < end; addr = next, pte++) {
> > + next = (addr + PAGE_SIZE) & PAGE_MASK;
> > + if (next > end)
> > + next = end;
> > +
> > + if (!pte_present(*pte))
> > + continue;
> > +
> > + spin_lock(&init_mm.page_table_lock);
> > + pte_clear(&init_mm, addr, pte);
> > + spin_unlock(&init_mm.page_table_lock);
> > + }
> > +
> > + flush_tlb_mm(&init_mm);
>
> Why call a flush here. we do that at the end of remove_page_table .
> Isn't that sufficient ?
All those lock/unlock ... what for ? Can't we just do the whole page ?
Also I agree, we can delay the flush of the PTEs to the end.
Ben.
next prev parent reply other threads:[~2016-12-19 20:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 19:50 [PATCH v3 0/5] powerpc/mm: enable memory hotplug on radix Reza Arbab
2016-12-15 19:50 ` [PATCH v3 1/5] powerpc/mm: set the radix linear page mapping size Reza Arbab
2016-12-19 8:58 ` Aneesh Kumar K.V
2016-12-19 20:53 ` Benjamin Herrenschmidt
2016-12-20 2:02 ` Aneesh Kumar K.V
2016-12-15 19:50 ` [PATCH v3 2/5] powerpc/mm: refactor {create, remove}_section_mapping() Reza Arbab
2016-12-19 9:00 ` Aneesh Kumar K.V
2016-12-19 18:00 ` [PATCH v3 2/5] powerpc/mm: refactor {create,remove}_section_mapping() Reza Arbab
2016-12-20 5:26 ` Balbir Singh
2016-12-15 19:50 ` [PATCH v3 3/5] powerpc/mm: add radix__create_section_mapping() Reza Arbab
2016-12-19 9:04 ` Aneesh Kumar K.V
2016-12-19 18:06 ` Reza Arbab
2016-12-21 7:03 ` Anshuman Khandual
2016-12-20 6:28 ` Balbir Singh
2016-12-20 15:32 ` Reza Arbab
2016-12-15 19:50 ` [PATCH v3 4/5] powerpc/mm: add radix__remove_section_mapping() Reza Arbab
2016-12-19 9:48 ` Aneesh Kumar K.V
2016-12-19 18:11 ` Reza Arbab
2016-12-19 20:59 ` Benjamin Herrenschmidt [this message]
2016-12-15 19:50 ` [PATCH v3 5/5] powerpc/mm: unstub radix__vmemmap_remove_mapping() Reza Arbab
2016-12-16 14:38 ` [PATCH v3 0/5] powerpc/mm: enable memory hotplug on radix Balbir Singh
2016-12-19 17:58 ` Reza Arbab
2016-12-21 6:54 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482181162.15937.32.camel@kernel.crashing.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=apopple@au1$(echo .)ibm.com \
--cc=arbab@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox