From: Bart Van Assche <Bart.VanAssche@sandisk•com>
To: "gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>
Cc: "linux-parisc@vger•kernel.org" <linux-parisc@vger•kernel.org>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
"ysato@users•sourceforge.jp" <ysato@users•sourceforge.jp>,
"linux-xtensa@linux-xtensa•org" <linux-xtensa@linux-xtensa•org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"jesper.nilsson@axis•com" <jesper.nilsson@axis•com>,
"mulix@mulix•org" <mulix@mulix•org>,
"hpa@zytor•com" <hpa@zytor•com>,
"catalin.marinas@arm•com" <catalin.marinas@arm•com>,
"uclinux-h8-devel@lists•sourceforge.jp"
<uclinux-h8-devel@lists•sourceforge.jp>,
"linux-hexagon@vger•kernel.org" <linux-hexagon@vger•kernel.org>,
"geoff@infradead•org" <geoff@infradead•org>,
"jcmvbkbc@gmail•com" <jcmvbkbc@gmail•com>,
"linux@armlinux•org.uk" <linux@armlinux•org.uk>,
"iommu@lists•linux-foundation.org"
<iommu@lists•linux-foundation.org>,
"linux-c6x-dev@linux-c6x•org" <linux-c6x-dev@linux-c6x•org>,
"linux-am33-list@redhat•com" <linux-am33-list@redhat•com>,
"linux-ia64@vger•kernel.org" <linux-ia64@vger•kernel.org>,
"linux-cris-kernel@axis•com" <linux-cris-kernel@axis•com>,
"linux-mips@linux-mips•org" <linux-mips@linux-mips•org>,
"linux-m68k@lists•linux-m68k.org"
<linux-m68k@lists•linux-m68k.org>,
"a-jacquiot@ti•com" <a-jacquiot@ti•com>,
"dalias@libc•org" <dalias@libc•org>,
"linux-metag@vger•kernel.org" <linux-metag@vger•kernel.org>,
"nios2-dev@lists•rocketboards.org"
<nios2-dev@lists•rocketboards.org>,
"linux-sh@vger•kernel.org" <linux-sh@vger•kernel.org>,
"shorne@gmail•com" <shorne@gmail•com>,
"lftan@altera•com" <lftan@altera•com>,
"deller@gmx•de" <deller@gmx•de>,
"jdmason@kudzu•us" <jdmason@kudzu•us>,
"linux-alpha@vger•kernel.org" <linux-alpha@vger•kernel.org>,
"openrisc@lists•librecores.org" <openrisc@lists•librecores.org>,
"sparclinux@vger•kernel.org" <sparclinux@vger•kernel.org>,
"chris@zankel•net" <chris@zankel•net>,
"davem@davemloft•net" <davem@davemloft•net>,
"joro@8bytes•org" <joro@8bytes•org>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"x86@kernel•org" <x86@kernel•org>,
"fenghua.yu@intel•com" <fenghua.yu@intel•com>,
"jejb@parisc-linux•org" <jejb@parisc-linux•org>,
"linux-snps-arc@lists•infradead.org"
<linux-snps-arc@lists•infradead.org>,
"msalter@redhat•com" <msalter@redhat•com>,
"dledford@redhat•com" <dledford@redhat•com>,
"adi-buildroot-devel@lists•sourceforge.net"
<adi-buildroot-devel@lists•sourceforge.net>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"starvik@axis•com" <starvik@axis•com>,
"dhowells@redhat•com" <dhowells@redhat•com>,
"hskinnemoen@gmail•com" <hskinnemoen@gmail•com>,
"mingo@redhat•com" <mingo@redhat•com>,
"stefan.kristiansson@saunalahti•fi"
<stefan.kristiansson@saunalahti•fi>,
"tony.luck@intel•com" <tony.luck@intel•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"jonas@southpole•se" <jonas@southpole•se>,
"geert@linux-m68k•org" <geert@linux-m68k•org>,
"egtvedt@samfundet•no" <egtvedt@samfundet•no>,
"will.deacon@arm•com" <will.deacon@arm•com>,
"linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>
Subject: Re: [PATCH 2/9] Move dma_ops from archdata into struct device
Date: Wed, 11 Jan 2017 18:03:15 +0000 [thread overview]
Message-ID: <1484157772.2619.12.camel@sandisk.com> (raw)
In-Reply-To: <20170111064624.GA26893@kroah.com>
On Wed, 2017-01-11 at 07:46 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote:
> > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to
> > transfer data between memory and PCIe adapter. Because of performance
> > reasons it is important that the CPU cache is not flushed when such
> > drivers transfer data. Make this possible by allowing these drivers to
> > override the dma_map_ops pointer. Additionally, introduce the function
> > set_dma_ops() that will be used by a later patch in this series.
> >=20
> > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk•com>
> > Cc: [ ... ]
>=20
> That's a crazy cc: list, you should break this up into smaller pieces,
> otherwise it's going to bounce...
That's a subset of what scripts/get_maintainer.pl came up with. Suggestions
for a more appropriate cc-list for a patch like this that touches all
architectures would be welcome.
> > diff --git a/include/linux/device.h b/include/linux/device.h
> > index 491b4c0ca633..c7cb225d36b0 100644
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -885,6 +885,8 @@ struct dev_links_info {
> > =A0 * a higher-level representation of the device.
> > =A0 */
> > =A0struct device {
> > + const struct dma_map_ops *dma_ops; /* See also get_dma_ops() */
> > +
> > =A0 struct device *parent;
> > =A0
> > =A0 struct device_private *p;
>=20
> Why not put this new pointer down with the other dma fields in this
> structure?=A0=A0Any specific reason it needs to be first?
Are there CPU architectures for which access to the first member of a
structure can be encoded and/or executed more efficiently than access to
other members of a structure? If not, I'm fine with moving the new pointer
further down.
Bart.=
next prev parent reply other threads:[~2017-01-11 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170111005648.14988-1-bart.vanassche@sandisk.com>
2017-01-11 0:56 ` [PATCH 1/9] treewide: Constify most dma_map_ops structures Bart Van Assche
2017-01-11 0:56 ` [PATCH 2/9] Move dma_ops from archdata into struct device Bart Van Assche
2017-01-11 6:46 ` Greg Kroah-Hartman
2017-01-11 18:03 ` Bart Van Assche [this message]
2017-01-11 20:29 ` gregkh
2017-01-11 6:48 ` Greg Kroah-Hartman
2017-01-11 18:17 ` Bart Van Assche
2017-01-11 20:31 ` gregkh
2017-01-11 22:28 ` Bart Van Assche
2017-01-12 7:35 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484157772.2619.12.camel@sandisk.com \
--to=bart.vanassche@sandisk$(echo .)com \
--cc=a-jacquiot@ti$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=dledford@redhat$(echo .)com \
--cc=egtvedt@samfundet$(echo .)no \
--cc=fenghua.yu@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=geoff@infradead$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jdmason@kudzu$(echo .)us \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=joro@8bytes$(echo .)org \
--cc=lftan@altera$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=msalter@redhat$(echo .)com \
--cc=mulix@mulix$(echo .)org \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=starvik@axis$(echo .)com \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox