Subject: Re: [PATCH] qe: fix compile issue for arm64

From: Scott Wood <[email-masked]>
Date: Sun, 23 Jul 2017 22:32:35 -0500

On Mon, 2017-07-24 at 02:09 +0000, Qiang Zhao wrote:
> On Fri, 2017-07-21 at 02:34PM, Michael Ellerman <[email-masked]> wrote:
> 
> > -----Original Message-----
> > From: Michael Ellerman [mailto:[email-masked]]
> > Sent: Friday, July 21, 2017 2:34 PM
> > To: Qiang Zhao <[email-masked]>; [email-masked]
> > Cc: [email-masked]; [email-masked]; linux-
> > [email-masked]; Qiang Zhao <[email-masked]>
> > Subject: Re: [PATCH] qe: fix compile issue for arm64
> > 
> > Zhao Qiang <[email-masked]> writes:
> > 
> > > Signed-off-by: Zhao Qiang <[email-masked]>
> > > ---
> > >  drivers/soc/fsl/qe/qe.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> > > 2ef6fc6..d48fa4a 100644
> > > --- a/drivers/soc/fsl/qe/qe.c
> > > +++ b/drivers/soc/fsl/qe/qe.c
> > > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate,
> > 
> > unsigned int multiplier)
> > >  	/* Errata QE_General4, which affects some MPC832x and MPC836x
> > 
> > SOCs, says
> > >  	   that the BRG divisor must be even if you're not using
> > > divide-by-16
> > >  	   mode. */
> > > +#ifdef CONFIG_PPC
> > >  	if (pvr_version_is(PVR_VER_836x) ||
> > > pvr_version_is(PVR_VER_832x)
> > > +#endif
> > >  		if (!div16 && (divisor & 1) && (divisor > 3))
> > >  			divisor++;
> > 
> > Are you sure that's what you want to do on arm64 ?
> 
> Is there any problem?
> 
> Best Regards
> Qiang Zhao

The comment says the workaround applies to MPC832x and MPC836x, but you're
applying the workaround on arm64 as well.

-Scott