From: Joe Perches <joe@perches•com>
To: SF Markus Elfring <elfring@users•sourceforge.net>,
alsa-devel@alsa-project•org, linuxppc-dev@lists•ozlabs.org,
Fabio Estevam <fabio.estevam@nxp•com>,
Jaroslav Kysela <perex@perex•cz>,
Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>,
Nicolin Chen <nicoleotsuka@gmail•com>,
Takashi Iwai <tiwai@suse•com>, Timur Tabi <timur@tabi•org>,
Xiubo Li <Xiubo.Lee@gmail•com>
Cc: LKML <linux-kernel@vger•kernel.org>, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
Date: Fri, 11 Aug 2017 07:44:31 -0700 [thread overview]
Message-ID: <1502462671.3099.13.camel@perches.com> (raw)
In-Reply-To: <671f4a88-bee9-85b4-ea9b-68abcdb40443@users.sourceforge.net>
On Fri, 2017-08-11 at 15:32 +0200, SF Markus Elfring wrote:
> From 885ccd6c63291dcd4854a0cbaab5188cdc3db805 Mon Sep 17 00:00:00 2001
> From: Markus Elfring <elfring@users•sourceforge.net>
> Date: Fri, 11 Aug 2017 15:10:43 +0200
> Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
This doesn't have anything to do with refactoring strings.
Just note that allocations without GFP_NOWARN do a dump_stack()
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
[]
> @@ -282,7 +282,5 @@ static int fsl_asrc_dma_startup(struct snd_pcm_substream *substream)
> - if (!pair) {
> - dev_err(dev, "failed to allocate pair\n");
> + if (!pair)
> return -ENOMEM;
> - }
Use normal diff output that shows 3 lines of context
above and below the patched lines.
prev parent reply other threads:[~2017-08-11 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 13:32 [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-08-11 14:44 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502462671.3099.13.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=elfring@users$(echo .)sourceforge.net \
--cc=fabio.estevam@nxp$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=timur@tabi$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox