From: Joe Perches <joe@perches•com>
To: Michael Ellerman <mpe@ellerman•id.au>,
Balbir Singh <bsingharora@gmail•com>,
Colin King <colin.king@canonical•com>
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists•ozlabs.org>,
kernel-janitors@vger•kernel.org,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations
Date: Fri, 08 Dec 2017 04:23:49 -0800 [thread overview]
Message-ID: <1512735829.1845.15.camel@perches.com> (raw)
In-Reply-To: <87efo5h1yh.fsf@concordia.ellerman.id.au>
On Fri, 2017-12-08 at 22:51 +1100, Michael Ellerman wrote:
> Balbir Singh <bsingharora@gmail•com> writes:
>
> > On Thu, Dec 7, 2017 at 10:01 PM, Colin King <colin.king@canonical•com> wrote:
> > > From: Colin Ian King <colin.king@canonical•com>
> > >
> > > Use the ARRAY_SIZE macro on several arrays to determine their size.
> > > Improvement suggested by coccinelle.
> >
> > This file is taken from binutils and re-licensed. Keeping the file
> > as-is helps apply newer patches easily on top as opposed to redoing
> > the changes. I would prefer not to move to ARRAY_SIZE and stick to
> > what's already in the file.
>
> Yep.
>
> Thanks but no thanks on this one Colin.
>
> Is there a checkpatch blacklist anywhere? So we don't keep discovering
> things in this file that need to be fixed?
Nope. Besides, this came via a coccinelle suggestion.
What might be useful is a generic marker somewhere in
a file that shows the file as a generated file and
indicates the file should not otherwise be modified.
prev parent reply other threads:[~2017-12-08 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 11:01 [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations Colin King
2017-12-08 3:37 ` Balbir Singh
2017-12-08 11:51 ` Michael Ellerman
2017-12-08 12:23 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512735829.1845.15.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=colin.king@canonical$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox