Subject: Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

From: Joe Perches <[email-masked]>
Date: Fri, 08 Dec 2017 04:23:49 -0800

On Fri, 2017-12-08 at 22:51 +1100, Michael Ellerman wrote:
> Balbir Singh <[email-masked]> writes:
> 
> > On Thu, Dec 7, 2017 at 10:01 PM, Colin King <[email-masked]> wrote:
> > > From: Colin Ian King <[email-masked]>
> > > 
> > > Use the ARRAY_SIZE macro on several arrays to determine their size.
> > > Improvement suggested by coccinelle.
> > 
> > This file is taken from binutils and re-licensed. Keeping the file
> > as-is helps apply newer patches easily on top as opposed to redoing
> > the changes. I would prefer not to move to ARRAY_SIZE and stick to
> > what's already in the file.
> 
> Yep.
> 
> Thanks but no thanks on this one Colin.
> 
> Is there a checkpatch blacklist anywhere? So we don't keep discovering
> things in this file that need to be fixed?

Nope.  Besides, this came via a coccinelle suggestion.

What might be useful is a generic marker somewhere in
a file that shows the file as a generated file and
indicates the file should not otherwise be modified.