Subject: Re: take in count O_NONBLOCK flag for rtas log

From: David Howells <[email-masked]>
Date: Thu, 25 Sep 2008 22:13:05 +0100

Vitaly Mayatskikh <[email-masked]> wrote:

> +		if (!logging_enabled) {
> +			spin_unlock_irqrestore(&rtasd_log_lock, s);
> +			error = -ENODATA;
> +			goto out;
> +		} else
> +			nvram_clear_error_log();

The 'else' here is unnecessary.  It's preceded inside the curlies by a goto.

David