From: Nathaniel Case <ncase@xes-inc•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx
Date: Wed, 10 Jun 2009 22:40:33 -0500 [thread overview]
Message-ID: <155ffc0deec796912080304f76bb09e7@xes-inc.com> (raw)
In-Reply-To: <094F1487-85D2-400A-A2B6-5ED54685907A@kernel.crashing.org>
On Wed, 10 Jun 2009 21:54:01 -0500, Kumar Gala <galak@kernel•crashing.org>
wrote:
>> #define TARGET_85xx
>> +#define TARGET_HAS_ETH3
>
> This is problematic in that we'd be changing the memory layout of the
> bd_t and not ALL 85xx's have HAS_ETH3 set.
It shouldn't be problematic. The bi_enet3addr field is at the end of the
structure on MPC85xx. The only fields after it in ppcboot.h are
4xx-specific
fields. I believe the MAC addresses were placed at the end of the struct
for
this very reason.
--
Nate Case <ncase@xes-inc•com>
next prev parent reply other threads:[~2009-06-11 3:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 22:17 [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx Nate Case
2009-06-11 2:54 ` Kumar Gala
2009-06-11 3:40 ` Nathaniel Case [this message]
2009-06-11 3:44 ` Kumar Gala
2009-06-11 3:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155ffc0deec796912080304f76bb09e7@xes-inc.com \
--to=ncase@xes-inc$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox