From: "Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>
To: Aravinda Prasad <aravinda@linux•vnet.ibm.com>,
Nathan Lynch <nathanl@linux•ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] powerpc/pseries: Fix maximum memory value
Date: Fri, 28 Jun 2019 23:08:57 +0530 [thread overview]
Message-ID: <1561743225.hrre8pgw6j.naveen@linux.ibm.com> (raw)
In-Reply-To: <87tvc9sjrb.fsf@linux.ibm.com>
Nathan Lynch wrote:
> Aravinda Prasad <aravinda@linux•vnet.ibm.com> writes:
>> Calculating the maximum memory based on the number of lmbs
>> and lmb size does not account for the RMA region. Hence
>> use memory_hotplug_max(), which already accounts for the
>> RMA region, to fetch the maximum memory value. Thanks to
>> Nathan Lynch for suggesting the memory_hotplug_max()
>> function.
>
> Well, I hope I haven't led you astray... will it give you the desired
> result on a kernel configured without memory hotplug support, booted in
> an LPAR with some huge pages configured?
>
> If so, then
> Acked-by: Nathan Lynch <nathanl@linux•ibm.com>
>
> It would likely help with review and future maintenance if the semantics
> and intended use of the MaxMem field are made a little more
> explicit. For example, is it supposed to include persistent memory?
> Perhaps a follow-up patch could address this. Or maybe I'm overthinking
> it.
This was primarily aimed to replicate what AIX lparstat does and
documentation (*) just says:
Maximum Memory
Maximum possible amount of Memory.
I think this mirrors the maximum memory value set in the LPAR profile,
and this provides a way to obtain that value from within the LPAR.
This doesn't necessarily answer your question, but that's at least the
reference.
(*)
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.cmds3/lparstat.htm
- Naveen
next prev parent reply other threads:[~2019-06-28 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 6:53 [PATCH v2] powerpc/pseries: Fix maximum memory value Aravinda Prasad
2019-06-28 17:27 ` Nathan Lynch
2019-06-28 17:38 ` Naveen N. Rao [this message]
2019-06-28 18:19 ` Nathan Lynch
2019-07-04 11:13 ` Michael Ellerman
2019-07-04 11:30 ` Aravinda Prasad
2019-07-01 4:03 ` Aravinda Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561743225.hrre8pgw6j.naveen@linux.ibm.com \
--to=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=aravinda@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nathanl@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox