From: Nicholas Piggin <npiggin@gmail•com>
To: Haren Myneni <haren@linux•ibm.com>,
herbert@gondor•apana.org.au, linux-crypto@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, mpe@ellerman•id.au
Subject: Re: [PATCH v4 03/16] powerpc/vas: Add platform specific user window operations
Date: Thu, 03 Jun 2021 14:05:20 +1000 [thread overview]
Message-ID: <1622692598.4iphcb4vdf.astroid@bobo.none> (raw)
In-Reply-To: <f4fb4b7bb98580ae3c025d83148a6406541de892.camel@linux.ibm.com>
Excerpts from Haren Myneni's message of May 21, 2021 7:30 pm:
>
> PowerNV uses registers to open/close VAS windows, and getting the
> paste address. Whereas the hypervisor calls are used on PowerVM.
>
> This patch adds the platform specific user space window operations
> and register with the common VAS user space interface.
Basic idea makes sense. I don't understand this code in detail though.
A couple of things,
>
> Signed-off-by: Haren Myneni <haren@linux•ibm.com>
> ---
> arch/powerpc/include/asm/vas.h | 14 +++++-
> arch/powerpc/platforms/book3s/vas-api.c | 52 ++++++++++++---------
> arch/powerpc/platforms/powernv/vas-window.c | 46 +++++++++++++++++-
> 3 files changed, 89 insertions(+), 23 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/vas.h b/arch/powerpc/include/asm/vas.h
> index 6076adf9ab4f..668303198772 100644
> --- a/arch/powerpc/include/asm/vas.h
> +++ b/arch/powerpc/include/asm/vas.h
> @@ -5,6 +5,7 @@
>
> #ifndef _ASM_POWERPC_VAS_H
> #define _ASM_POWERPC_VAS_H
> +#include <uapi/asm/vas-api.h>
>
> struct vas_window;
>
> @@ -48,6 +49,16 @@ enum vas_cop_type {
> VAS_COP_TYPE_MAX,
> };
>
> +/*
> + * User space window operations used for powernv and powerVM
> + */
> +struct vas_user_win_ops {
> + struct vas_window * (*open_win)(struct vas_tx_win_open_attr *,
> + enum vas_cop_type);
> + u64 (*paste_addr)(void *);
> + int (*close_win)(void *);
Without looking further into the series, why do these two take void *
when the first returns a vas_window * which appears to be the required
argument to these?
> +static struct vas_user_win_ops vops = {
> + .open_win = vas_user_win_open,
> + .paste_addr = vas_user_win_paste_addr,
> + .close_win = vas_user_win_close,
> +};
const?
Thanks,
Nick
next prev parent reply other threads:[~2021-06-03 4:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 9:25 [PATCH v4 00/16] Enable VAS and NX-GZIP support on powerVM Haren Myneni
2021-05-21 9:28 ` [PATCH v4 01/16] powerpc/vas: Move VAS API to book3s common platform Haren Myneni
2021-06-03 3:32 ` Nicholas Piggin
2021-06-03 20:23 ` Haren Myneni
2021-05-21 9:29 ` [PATCH v4 02/16] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni
2021-05-21 9:30 ` [PATCH v4 03/16] powerpc/vas: Add platform specific user window operations Haren Myneni
2021-06-03 4:05 ` Nicholas Piggin [this message]
2021-06-03 20:25 ` Haren Myneni
2021-05-21 9:31 ` [PATCH v4 04/16] powerpc/vas: Create take/drop pid and mm references Haren Myneni
2021-06-03 4:21 ` Nicholas Piggin
2021-06-04 4:08 ` Haren Myneni
2021-06-05 0:31 ` Nicholas Piggin
2021-06-05 3:03 ` Nicholas Piggin
2021-05-21 9:32 ` [PATCH v4 05/16] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni
2021-06-03 4:26 ` Nicholas Piggin
2021-05-21 9:33 ` [PATCH v4 06/16] powerpc/vas: Define and use common vas_window struct Haren Myneni
2021-06-03 4:38 ` Nicholas Piggin
2021-06-04 4:35 ` Haren Myneni
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 21:19 ` Haren Myneni
2021-05-21 9:34 ` [PATCH v4 07/16] powerpc/pseries/vas: Define VAS/NXGZIP HCALLs and structs Haren Myneni
2021-06-03 4:47 ` Nicholas Piggin
2021-06-04 1:30 ` Haren Myneni
2021-06-05 0:37 ` Nicholas Piggin
2021-05-21 9:34 ` [PATCH v4 08/16] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni
2021-05-21 9:35 ` [PATCH v4 09/16] powerpc/pseries/vas: Add HCALL wrappers for VAS handling Haren Myneni
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 21:53 ` Haren Myneni
2021-05-21 9:38 ` [PATCH v4 10/16] powerpc/pseries/vas: Implement getting capabilities from hypervisor Haren Myneni
2021-05-21 9:39 ` [PATCH v4 11/16] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni
2021-05-21 9:39 ` [PATCH v4 12/16] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni
2021-06-03 5:48 ` Nicholas Piggin
2021-06-04 1:19 ` Haren Myneni
2021-06-05 0:43 ` Nicholas Piggin
2021-05-21 9:40 ` [PATCH v4 13/16] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni
2021-05-21 9:41 ` [PATCH v4 14/16] crypto/nx: Register and unregister VAS interface Haren Myneni
2021-06-03 4:59 ` Nicholas Piggin
2021-05-21 9:41 ` [PATCH v4 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni
2021-05-21 9:42 ` [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni
2021-06-03 4:57 ` Nicholas Piggin
2021-06-04 1:02 ` Haren Myneni
2021-06-04 11:52 ` Michael Ellerman
2021-06-04 17:23 ` Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622692598.4iphcb4vdf.astroid@bobo.none \
--to=npiggin@gmail$(echo .)com \
--cc=haren@linux$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox