From: "Albrecht Dreß" <albrecht.dress@arcor•de>
To: grant.likely@secretlab•ca
Cc: linuxppc-dev@ozlabs•org, devicetree-discuss@lists•ozlabs.org,
wim@iguana•be
Subject: Aw: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api
Date: Wed, 11 Nov 2009 09:32:22 +0100 (CET) [thread overview]
Message-ID: <16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local> (raw)
In-Reply-To: <fa686aa40911101307p12bba31s491ef1d8812ca033@mail.gmail.com>
Hi Grant:
O.k., thanks for your comments. If Wim doesn't have any objections to it, =
I will provide a merged patch. One consequence I forgot to mention is that=
we loose the ability to build the wdt support as module, but I don't think=
it's a real problem.
I think we still should keep the kernel config option enable/disable the wd=
t support, which would mask out the wdt code if disabled. Is that ok for y=
ou?
Thanks, Albrecht.
----- Original Nachricht ----
Von: Grant Likely <grant.likely@secretlab•ca>
An: Albrecht Dre=DF <albrecht.dress@arcor•de>
Datum: 10.11.2009 22:07
Betreff: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api
> On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dre=DF <albrecht.dress@arcor•de=
>
> wrote:
> > Hi Grant:
> >
> > Am 10.11.09 20:59 schrieb(en) Grant Likely:
> >>
> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dre=DF
> <albrecht.dress@arcor•de>
> >> wrote:
> >> > Use the MPC5200 GPT api for the WDT which drastically simplifies thi=
s
> >> > file.
> >> >
> >> > Signed-off-by: Albrecht Dre=DF <albrecht.dress@arcor•de>
> >> > ---
> >> >
> >> > =A0drivers/watchdog/mpc5200_wdt.c | =A0246
> >> > +++++++++++-----------------------------
> >> > =A01 files changed, 65 insertions(+), 181 deletions(-)
> >>
> >>
> >> Can the WDT functionality just be merged entirely into
> >> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for
> >> this file entirely? =A0I think I'd rather have all the GPT "built in"
> >> behaviour handled by a single driver.
> >
> > I also thought about it, as it has IMHO the cleaner code, and it would
> have
> > the extra benefit that the gpt-wdt api doesn't need to be public.
> >
> > However, the reasons I hesitated to do so are:
> > - I don't want to remove a file someone else wrote (even it doesn't
> work);
>=20
> Shouldn't be a problem, and I'll handle the fallout if it is.
>=20
> > - WDT code is shifted from drivers/watchdog to
> arch/powerpc/platforms/52xx
> > which might not be the "logical" place from the directory layout's pov;
>=20
> There is precedence of this in the past, particularly on arch or
> platform specific hardware drivers and multifunction devices. (Heck,
> that's almost entirely what arch/powerpc/sysdev is). I'm not
> concerned.
>=20
> > - a file living in arch/powerpc/platforms/52xx depends upon config
> options
> > set from drivers/watchdog/Kconfig which may be confusing.
>=20
> I'm not concerned about this either.
>=20
> > You see these are more political/cosmetical questions, so I would prefe=
r
> to
> > leave the decision to the maintainers (i.e. you and Wim). =A0Preparing =
a
> fully
> > merged driver is actually a matter of minutes!
>=20
> Do it. I'll champion getting it in. Wim, do you have any issues with
> this?
>=20
> g.
>=20
> --=20
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>=20
Jetzt NEU: Do it youself E-Cards bei Arcor.de!
Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empf=E4nger eine=
ganz pers=F6nliche Freude!
E-Card Marke Eigenbau: HIER KLICKEN: http://www.arcor.de/rd/footer.ecard
next prev parent reply other threads:[~2009-11-11 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 19:43 [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api Albrecht Dreß
2009-11-10 19:59 ` Grant Likely
2009-11-10 20:26 ` Albrecht Dreß
2009-11-10 21:07 ` Grant Likely
2009-11-11 8:32 ` Albrecht Dreß [this message]
2009-11-11 20:18 ` Grant Likely
2009-11-12 21:36 ` Wim Van Sebroeck
2009-11-13 6:21 ` Grant Likely
2009-12-08 20:48 ` Wim Van Sebroeck
2009-12-08 21:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local \
--to=albrecht.dress@arcor$(echo .)de \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=wim@iguana$(echo .)be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox