From: "Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>
Cc: Jordan Niethe <jniethe5@gmail•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Masami Hiramatsu <mhiramat@kernel•org>
Subject: Re: [PATCH 5/5] powerpc/kprobes: Remove unnecessary headers from kprobes
Date: Tue, 08 Nov 2022 15:36:30 +0530 [thread overview]
Message-ID: <1667901397.uwblu29kpn.naveen@linux.ibm.com> (raw)
In-Reply-To: <9747a449-a790-707a-e4f5-174f4bf52007@csgroup.eu>
Christophe Leroy wrote:
>
>
> Le 20/10/2022 à 19:29, Naveen N. Rao a écrit :
>> Many of these headers are not necessary since those are included
>> indirectly, or the code using those headers has been removed.
>
> It is usually not a good idea to not include headers because they are
> already included indirectly. If one day for some reason de indirect link
> gets removed, then your file doesn't build anymore.
I agree with that in general.
The motivation for this patch was to remove <linux/preempt.h> from
kprobes-ftrace.c since we got rid of explicit preempt disable/enable
calls in the past. We have also removed explicit irq disable from this
path. <linux/kprobes.h> includes <linux/ftrace.h> and <asm/kprobes.h>
includes <linux/ptrace.h> so those could go too.
I don't expect those header dependencies to change, so I think this
patch is ok.
- Naveen
next prev parent reply other threads:[~2022-11-08 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 17:28 [PATCH 0/5] powerpc/kprobes: preempt related changes and cleanups Naveen N. Rao
2022-10-20 17:28 ` [PATCH 1/5] powerpc/kprobes: Remove preempt disable around call to get_kprobe() in arch_prepare_kprobe() Naveen N. Rao
2022-11-07 10:14 ` Nicholas Piggin
2022-11-08 10:33 ` Naveen N. Rao
2022-10-20 17:28 ` [PATCH 2/5] powerpc/kprobes: Have optimized_callback() use preempt_enable() Naveen N. Rao
2022-11-07 10:18 ` Nicholas Piggin
2022-10-20 17:28 ` [PATCH 3/5] powerpc/kprobes: Use preempt_enable() rather than the no_resched variant Naveen N. Rao
2022-11-07 10:29 ` Nicholas Piggin
2022-10-20 17:29 ` [PATCH 4/5] powerpc/kprobes: Setup consistent pt_regs across kprobes, optprobes and KPROBES_ON_FTRACE Naveen N. Rao
2022-11-07 11:15 ` Nicholas Piggin
2022-11-08 10:52 ` Naveen N. Rao
2022-10-20 17:29 ` [PATCH 5/5] powerpc/kprobes: Remove unnecessary headers from kprobes Naveen N. Rao
2022-11-02 8:36 ` Christophe Leroy
2022-11-08 10:06 ` Naveen N. Rao [this message]
2022-11-07 11:24 ` [PATCH 0/5] powerpc/kprobes: preempt related changes and cleanups Nicholas Piggin
2022-11-30 9:24 ` (subset) " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667901397.uwblu29kpn.naveen@linux.ibm.com \
--to=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=jniethe5@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhiramat@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox