Subject: Re: [PATCH] Add AMCC Arches DTS

From: Victor Gallardo <[email-masked]>
Date: Fri, 18 Jul 2008 15:10:25 -0700 (PDT)

> So its a S29GL256 with 32MBytes...

Yes.

> ... and this partition scheme is for 64MByte.

You, you are correct. I'll fix this.

> <snip>
>
>> +			EMAC0: ethernet@ef600e00 {
>> +				device_type = "network";
>> +				compatible = "ibm,emac-460gt", "ibm,emac4";
>
>That's not correct anymore. A recent patch from Grant Erickson
[ibm_newemac: 
>Parameterize EMAC Multicast Match Handling] changed these compatible
entries. 
>You should use "ibm_emac4sync" here now.

OK. Will change.

>> +				interrupt-parent = <&EMAC0>;
>> +				interrupts = <0 1>;
>> +				#interrupt-cells = <1>;
>> +				#address-cells = <0>;
>> +				#size-cells = <0>;
>> +				interrupt-map = </*Status*/ 0 &UIC2 10 4
>> +						 /*Wake*/   1 &UIC2 14 4>;
>> +				reg = <ef600e00 70>;
>
> The patch mentioned above also fixed the incorrect size here. Please fix
> this 
> too.

Ok. Will fix.

>SGMII, right?

Yes, that is correct. I will fix this also.

Thanks Stefan,

Victor Gallardo

-- 
View this message in context: http://www.nabble.com/-PATCH--Add-AMCC-Arches-DTS-tp18480767p18538522.html
Sent from the linuxppc-embedded mailing list archive at Nabble.com.