From: Alistair Popple <alistair@popple•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>
Cc: linuxppc-dev@lists•ozlabs.org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Russell Currey <ruscur@russell•cc>,
Balbir Singh <bsingharora@gmail•com>,
Stewart Smith <stewart@linux•ibm.com>
Subject: Re: [PATCH kernel] powerpc/ioda/npu2: Call hot reset skiboot hook when disabling NPU
Date: Thu, 12 Jul 2018 11:38:34 +1000 [thread overview]
Message-ID: <1903233.NnVPaYN7RK@new-mexico> (raw)
In-Reply-To: <20180711194510.0bc8dc39@aik.ozlabs.ibm.com>
Hi Alexey,
On Wednesday, 11 July 2018 7:45:10 PM AEST Alexey Kardashevskiy wrote:
> On Thu, 7 Jun 2018 17:06:07 +1000
> Alexey Kardashevskiy <aik@ozlabs•ru> wrote:
>
> > This brings NPU2 in a safe mode when it does not throw HMI if GPU
> > coherent memory is gone.
It might be helpful if you you could describe the problem and what you are
trying to solve in a bit more depth. Assuming the memory was online how are you
offlining it? If the memory has been online merely fencing/hot-resetting the
NVLink is likely not sufficient as you also need to flush caches prior to taking
the links down.
- Alistair
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
>
>
> Anyone, ping?
>
>
> > ---
> >
> > The main aim for this is nvlink2 pass through, helps a lot.
> >
> >
> > ---
> > arch/powerpc/platforms/powernv/pci-ioda.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> > index 66c2804..29f798c 100644
> > --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> > @@ -3797,6 +3797,16 @@ static void pnv_pci_release_device(struct pci_dev *pdev)
> > pnv_ioda_release_pe(pe);
> > }
> >
> > +void pnv_npu_disable_device(struct pci_dev *pdev)
> > +{
> > + struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev);
> > + struct eeh_pe *eehpe = edev ? edev->pe : NULL;
> > +
> > + if (eehpe && eeh_ops && eeh_ops->reset) {
> > + eeh_ops->reset(eehpe, EEH_RESET_HOT);
> > + }
> > +}
> > +
> > static void pnv_pci_ioda_shutdown(struct pci_controller *hose)
> > {
> > struct pnv_phb *phb = hose->private_data;
> > @@ -3841,6 +3851,7 @@ static const struct pci_controller_ops pnv_npu_ioda_controller_ops = {
> > .reset_secondary_bus = pnv_pci_reset_secondary_bus,
> > .dma_set_mask = pnv_npu_dma_set_mask,
> > .shutdown = pnv_pci_ioda_shutdown,
> > + .disable_device = pnv_npu_disable_device,
> > };
> >
> > static const struct pci_controller_ops pnv_npu_ocapi_ioda_controller_ops = {
>
>
>
> --
> Alexey
>
next prev parent reply other threads:[~2018-07-12 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 7:06 [PATCH kernel] powerpc/ioda/npu2: Call hot reset skiboot hook when disabling NPU Alexey Kardashevskiy
2018-07-11 9:45 ` Alexey Kardashevskiy
2018-07-12 1:38 ` Alistair Popple [this message]
2018-07-14 11:34 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1903233.NnVPaYN7RK@new-mexico \
--to=alistair@popple$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ruscur@russell$(echo .)cc \
--cc=stewart@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox