public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat•com>
To: James Bottomley <James.Bottomley@SteelEye•com>,
	akpm@osdl•org, jens.axboe@oracle•com
Cc: fujita.tomonori@lab•ntt.co.jp, linux-scsi@vger•kernel.org,
	Gala Kumar-B11780 <kumar.gala@freescale•com>,
	linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: CONFIG_BLK_DEV_BSG=n
Date: Mon, 17 Sep 2007 15:46:30 +0100	[thread overview]
Message-ID: <19650.1190040390@redhat.com> (raw)
In-Reply-To: <1189800008.3343.21.camel@localhost.localdomain>


James Bottomley <James.Bottomley@SteelEye•com> wrote:

> > Which solution would you be more comfortable with?
> 
> The one which is currently in -mm is this one:
> 
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a

In my opinion, this is the wrong fix.  There shouldn't be anything in the
kernel using stuff from bsg.h if CONFIG_BLOCK=n, so there should be an error if
anything tries to.  The correct fix is to exclude the non-userspace-visible
contents of bsg.h with #ifdef CONFIG_BLOCK, not to declare things that we've
tried to make sure specifically aren't declared.

David
---

[PATCH] VFS: Make BSG declarations dependent on CONFIG_BLOCK

From: David Howells <dhowells@redhat•com>

Make BSG function declarations dependent on CONFIG_BLOCK as they are not
compilable if the block layer is compiled out.

Signed-off-by: David Howells <dhowells@redhat•com>
---

 include/linux/bsg.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/bsg.h b/include/linux/bsg.h
index 60e377b..28f5d44 100644
--- a/include/linux/bsg.h
+++ b/include/linux/bsg.h
@@ -52,6 +52,7 @@ struct sg_io_v4 {
 };
 
 #ifdef __KERNEL__
+#ifdef CONFIG_BLOCK
 
 #if defined(CONFIG_BLK_DEV_BSG)
 struct bsg_class_device {
@@ -73,6 +74,7 @@ static inline void bsg_unregister_queue(struct request_queue *rq)
 }
 #endif
 
+#endif /* CONFIG_BLOCK */
 #endif /* __KERNEL__ */
 
 #endif

  reply	other threads:[~2007-09-17 14:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 19:50 CONFIG_BLK_DEV_BSG=n Medve Emilian-EMMEDVE1
2007-09-14 20:00 ` CONFIG_BLK_DEV_BSG=n James Bottomley
2007-09-17 14:46   ` David Howells [this message]
2007-09-19 12:53     ` CONFIG_BLK_DEV_BSG=n Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19650.1190040390@redhat.com \
    --to=dhowells@redhat$(echo .)com \
    --cc=James.Bottomley@SteelEye$(echo .)com \
    --cc=akpm@osdl$(echo .)org \
    --cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
    --cc=jens.axboe@oracle$(echo .)com \
    --cc=kumar.gala@freescale$(echo .)com \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox