From: Benjamin Herrenschmidt <bh40@calva•net>
To: Geert Uytterhoeven <geert@linux-m68k•org>,
<linuxppc-dev@lists•linuxppc.org>
Subject: Re: mesh in 2.4.0-test1
Date: Sun, 4 Jun 2000 14:29:05 +0200 [thread overview]
Message-ID: <20000604122905.30293@192.168.1.10> (raw)
In-Reply-To: <Pine.LNX.4.05.10006041259560.514-100000@callisto.of.borg>
On Sun, Jun 4, 2000, Geert Uytterhoeven <geert@linux-m68k•org> wrote:
>take into account that on CHRP boxes with both ISA and OpenPIC, the interrupt
>numbers have to be fixed up. Below is the patch that made it work for me.
>
>Before I check it in into bitkeeper: should I replace the test
>
> _machine == _MACH_chrp
>
>by
>
> !strncmp(model, "IBM,LongTrail", 13)
>
>or are there other CHRP models bitten by this as well?
Hum, that's a side effect of enabling the new interrupt tree parsing on
all machines. Well, that's more or less my fault: the pmac_newworld
variable gets set to 1 on CHRP, thus enabling the new interrupt tree
parsing on them.
A better fix would be to only enable pmac_newworld on pmacs. (But still
keep the interrupt tree parsing for chrp since it's basically a chrp
thing that Apple implemented in newworld machines).
Note that this problem may be present in recent 2.2.x kernels too.
However, a subtle difference in 2.2.x is that _machine may not be
initialized yet when finish_device_tree() is called.
I'll look into those today and push fixed to both bk trees.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2000-06-04 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-31 20:46 mesh in 2.4.0-test1 Geert Uytterhoeven
2000-06-01 1:39 ` Martin Costabel
2000-06-04 11:03 ` Geert Uytterhoeven
2000-06-04 12:29 ` Benjamin Herrenschmidt [this message]
2000-06-04 20:03 ` Benjamin Herrenschmidt
2003-12-31 22:50 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000604122905.30293@192.168.1.10 \
--to=bh40@calva$(echo .)net \
--cc=geert@linux-m68k$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox