Subject: Re: `planb' doesn't compile on recent BenH kernel.

From: Olaf Hering <[email-masked]>
Date: Wed, 1 Aug 2001 13:45:41 +0200

On Wed, Aug 01, Romain Dolbeau wrote:

>
> Hello,
>
> the `planb' module won't comiple on any recent BenH kernel
> (from rsync penguinppc.org::linux-2.4-benh).
>
> 2.4.6pre3 works fine. No 2.4.7* or 2.4.8* work for me.
> I think some newer 2.4.6pre* didn't work either.
>
> Apparently a locking mechanism was changed but
> not all instance updated:

The attached patch allows the compile. Do you have hardware to test? I
have a 7500 but no video hardware around.

Gruss Olaf

--
 $ man clone

BUGS
       Main feature not yet implemented...
--- ../tree/linux-2.4.6-pre6/drivers/media/video/planb.c	Thu Jun 28 10:39:31 2001
+++ linux/drivers/media/video/planb.c	Thu Jun 28 12:25:23 2001
@@ -82,7 +82,6 @@
 static int planb_open(struct video_device *, int);
 static void planb_close(struct video_device *);
 static int planb_ioctl(struct video_device *, unsigned int, void *);
-static int planb_init_done(struct video_device *);
 static int planb_mmap(struct video_device *, const char *, unsigned long);
 static void planb_irq(int, void *, struct pt_regs *);
 static void release_planb(void);
@@ -2071,7 +2070,6 @@
 #endif
 	pb->tab_size = PLANB_MAXLINES + 40;
 	pb->suspend = 0;
-	pb->lock = 0;
 	init_MUTEX(&pb->lock);
 	pb->ch1_cmd = 0;
 	pb->ch2_cmd = 0;