From: Hollis Blanchard <hollis@austin•ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: linuxppc-dev@lists•linuxppc.org
Subject: Re: VGA console endian bug
Date: Fri, 10 Aug 2001 16:13:35 -0500 [thread overview]
Message-ID: <20010810161335.A29271@austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.05.10108101040060.2083-100000@callisto.of.borg>; from geert@linux-m68k.org on Fri, Aug 10, 2001 at 10:41:39AM +0200
On Fri, Aug 10, 2001 at 10:41:39AM +0200, Geert Uytterhoeven wrote:
>
> On Thu, 9 Aug 2001, Hollis Blanchard wrote:
> > These two patches came from Daniel Berlin on July 9. They completely resolve
> > the VGA console backwards-endian problem for me on PPC. If they have Geert's
> > seal of approval ;) can they be committed?
> >
> > -Hollis
> >
> > --- linuxppc_2_4_devel/include/asm-ppc/vga.h.old Thu Aug 9 11:49:23 2001
> > +++ linuxppc_2_4_devel/include/asm-ppc/vga.h Thu Aug 9 11:49:42 2001
> > @@ -37,6 +37,9 @@
> >
> > #define VT_BUF_HAVE_MEMCPYW
> > #define scr_memcpyw memcpy
> > +#define VT_BUF_HAVE_MEMCPYF
> > +#define scr_memcpyw_to memcpy
> > +#define scr_memcpyw_from memcpy
> >
> > #endif /* !CONFIG_VGA_CONSOLE && !CONFIG_MDA_CONSOLE */
>
> The first I cannot approve: if scr_{write,read}w() swap bytes, how can it work
> if scr_memcpyw_{to,from}() don't swap bytes?
I have no idea. Perhaps those functions weren't used, and that's why it
appeared to work. I have not tried with only the second patch; perhaps that
will be enough...
> And where's the 3rd patch? I once posted a patch to fix a similar bug in
> drivers/char/console.c.
I can't find it in the linuxppc-dev archives. :(
-Hollis
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2001-08-10 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-09 16:52 VGA console endian bug Hollis Blanchard
2001-08-10 8:41 ` Geert Uytterhoeven
2001-08-10 21:13 ` Hollis Blanchard [this message]
2001-08-11 8:33 ` Geert Uytterhoeven
2001-08-11 8:45 ` Olaf Hering
2001-08-11 9:05 ` Olaf Hering
2001-08-11 9:52 ` Geert Uytterhoeven
2001-08-11 10:14 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010810161335.A29271@austin.ibm.com \
--to=hollis@austin$(echo .)ibm.com \
--cc=geert@linux-m68k$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox