From: Tom Rini <trini@kernel•crashing.org>
To: Val Henson <val@nmt•edu>
Cc: linuxppc-dev@lists•linuxppc.org
Subject: Re: [PATCH] adjust BAT mapping according to max_low_mem
Date: Sat, 9 Feb 2002 13:47:16 -0700 [thread overview]
Message-ID: <20020209204716.GA872@opus.bloom.county> (raw)
In-Reply-To: <20020208133604.H25005@boardwalk>
On Fri, Feb 08, 2002 at 01:36:04PM -0700, Val Henson wrote:
> I'm testing highmem by setting max_low_mem to 64MB and using 256MB RAM
> total (this does not trigger my SCSI bug). I had to change a few
> things in adjust_total_lowmem to force it to _not_ BAT map of all the
> RAM. I think the printout of residual is wrong but I'm not sure.
If I'm reading all of the code right, residual at this point should be
(total_lowmem (initial value) - ram mapped in BATs), so I think this:
> + /* adjust BAT block size to max_low_mem */
> + if (max_low_mem < bat_max)
> + bat_max = max_low_mem;
> +
> + /* adjust lowmem size to max_low_mem */
> + if (max_low_mem < total_lowmem)
> + total_lowmem = max_low_mem;
> +
> + ram = total_lowmem;
Should be:
/* adjust BAT block size to max_low_mem */
if (max_low_mem < bat_max)
bat_max = max_low_mem;
/* adjust lowmem size to max_low_mem */
if (max_low_mem < total_lowmem)
ram = max_low_mem;
else
ram = total_lowmem;
...
printk(KERN_INFO "Memory BAT mapping: BAT2=%ldMb, BAT3=%ldMb, "
"residual: %ldMb\n", __bat2 >> 20, __bat3 >> 20,
(total_lowmem - ram) >> 20);
Does this sound right?
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-02-09 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-08 20:36 [PATCH] adjust BAT mapping according to max_low_mem Val Henson
2002-02-09 20:47 ` Tom Rini [this message]
2002-02-09 21:20 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020209204716.GA872@opus.bloom.county \
--to=trini@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
--cc=val@nmt$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox