public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel•crashing.org>
To: Linux/PPC BK repository <linuxppc@helium•Harhan.ORG>
Cc: linuxppc-commit@source•mvista.com, linuxppc-dev@lists•linuxppc.org
Subject: Re: Incoming to helium.harhan.org:/home/linuxppc/linuxppc_2_4_alt
Date: Mon, 8 Apr 2002 08:20:26 -0700	[thread overview]
Message-ID: <20020408152026.GG2716@opus.bloom.county> (raw)
In-Reply-To: <200204060739.g367duV18841@helium.Harhan.ORG>


[Just some code comments for now, actual comments in another mail]

> ChangeSet
>   1.925 02/04/05 23:09:25 msokolov@helium•harhan.org +60 -0
[snip]
>   arch/ppc/kernel/setup.c
>     1.105 02/04/01 00:01:18 msokolov@helium•harhan.org +49 -5
>     Add generic PPC32 config

We shouldn't be #ifdef'ing externs, since it doesn't matter.  The
pmac/prep/chrp ones were hidden just because the line above was, iirc.

And the one downside to the GENERIC_PPC32 platform_init, is that we're
back to adding:
#ifdef CONFIG_x
 case _MACH_x:
  x_init(...);
  break;
#endif

Which I think Paul was happy to see die :)

[snip]
>   arch/ppc/config.in
>     1.127 02/03/31 23:58:43 msokolov@helium•harhan.org +18 -21
>     Add generic PPC32 config, implemented for
>     Adirondack, EV-64260A, and K2

Do any of these boards actually have an ISA slot?  IIRC, CONFIG_ISA is
used for stuff which could be plugged into an ISA slot, not so much
things that could be on the ISA bus.  Right now it's an ALL_PPC-only
option because it's actually needed for sound on some PReP boxes..

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

       reply	other threads:[~2002-04-08 15:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200204060739.g367duV18841@helium.Harhan.ORG>
2002-04-08 15:20 ` Tom Rini [this message]
2002-04-08 17:58   ` Incoming to helium.harhan.org:/home/linuxppc/linuxppc_2_4_alt benh
2002-04-08 18:57     ` Tom Rini
2002-04-08 18:40       ` Benjamin Herrenschmidt
2002-04-09  8:14         ` Geert Uytterhoeven
2002-04-09 10:08           ` benh
     [not found]   ` <0204081705.AA21087@ivan.Harhan.ORG>
2002-04-08 18:02     ` benh
2002-04-09 14:52     ` Tom Rini
2002-04-09 19:23       ` Michael Sokolov
2002-04-09 19:47         ` Tom Rini
2002-04-09 20:05           ` Michael Sokolov
2002-04-09 20:15             ` Daniel Jacobowitz
2002-04-10 15:09             ` Tom Rini
2002-04-11  3:11               ` Michael Sokolov
2002-04-11 15:29                 ` Tom Rini
2002-04-15 16:54         ` Troy Benjegerdes
2002-04-15 18:11 Michael Sokolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020408152026.GG2716@opus.bloom.county \
    --to=trini@kernel$(echo .)crashing.org \
    --cc=linuxppc-commit@source$(echo .)mvista.com \
    --cc=linuxppc-dev@lists$(echo .)linuxppc.org \
    --cc=linuxppc@helium$(echo .)Harhan.ORG \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox