Subject: Re: Incoming to helium.harhan.org:/home/linuxppc/linuxppc_2_4_alt

From: Tom Rini <[email-masked]>
Date: Mon, 8 Apr 2002 08:20:26 -0700

[Just some code comments for now, actual comments in another mail]

> ChangeSet
>   1.925 02/04/05 23:09:25 [email-masked] +60 -0
[snip]
>   arch/ppc/kernel/setup.c
>     1.105 02/04/01 00:01:18 [email-masked] +49 -5
>     Add generic PPC32 config

We shouldn't be #ifdef'ing externs, since it doesn't matter.  The
pmac/prep/chrp ones were hidden just because the line above was, iirc.

And the one downside to the GENERIC_PPC32 platform_init, is that we're
back to adding:
#ifdef CONFIG_x
 case _MACH_x:
  x_init(...);
  break;
#endif

Which I think Paul was happy to see die :)

[snip]
>   arch/ppc/config.in
>     1.127 02/03/31 23:58:43 [email-masked] +18 -21
>     Add generic PPC32 config, implemented for
>     Adirondack, EV-64260A, and K2

Do any of these boards actually have an ISA slot?  IIRC, CONFIG_ISA is
used for stuff which could be plugged into an ISA slot, not so much
things that could be on the ISA bus.  Right now it's an ALL_PPC-only
option because it's actually needed for sound on some PReP boxes..

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/