public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel•crashing.org>
To: "David M?ller (ELSOFT AG)" <d.mueller@elsoft•ch>
Cc: linuxppc-embedded@lists•linuxppc.org
Subject: Re: [PATCH] Several patches agains linuxppc_devel-2.4.19-pre8
Date: Wed, 15 May 2002 08:52:00 -0700	[thread overview]
Message-ID: <20020515155200.GN721@opus.bloom.county> (raw)
In-Reply-To: <3CE2481B.5070108@elsoft.ch>


On Wed, May 15, 2002 at 01:35:55PM +0200, "David M?ller (ELSOFT AG)" wrote:

> The attached patch fixes the following issues:

Looks good, except:
Don't #ifdef externs, if they aren't used it's OK.
Since this code only has to work in recent'ish kernels (in reality only
'current' kernels) don't bother with the
#ifdef MODULE_LICENSE
...
#endif

Just use it.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-05-15 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-15 11:35 [PATCH] Several patches agains linuxppc_devel-2.4.19-pre8 "David Müller (ELSOFT AG)"
2002-05-15 15:52 ` Tom Rini [this message]
2002-05-16  9:26   ` "David Müller (ELSOFT AG)"
2002-05-16 13:56     ` Tom Rini
2002-05-17  6:31       ` "David Müller (ELSOFT AG)"
2002-05-17 12:59 ` "David Müller (ELSOFT AG)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020515155200.GN721@opus.bloom.county \
    --to=trini@kernel$(echo .)crashing.org \
    --cc=d.mueller@elsoft$(echo .)ch \
    --cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox