From: David Gibson <david@gibson•dropbear.id.au>
To: Todd Poynor <tpoynor@mvista•com>
Cc: linuxppc-embedded@lists•linuxppc.org
Subject: Re: very minor 405GP and 405GPr PCI difference
Date: Wed, 9 Oct 2002 12:14:03 +1000 [thread overview]
Message-ID: <20021009021403.GQ32555@zax> (raw)
In-Reply-To: <3DA3347B.1000004@mvista.com>
On Tue, Oct 08, 2002 at 12:39:39PM -0700, Todd Poynor wrote:
>
> David Gibson wrote:
>
> >>Rainier (NP4GS3) PMM1 is setup specially in the existing code, is this
> >>no longer needed?
> >
> >
> >Well, I don't know if it's necessary - it's not there, because I
> >didn't notice the difference in the Rainier code before. Now that I
> >do look at it, I'm confused: it appears to be setting up both PMM0 and
> >PMM1 to map from the same PLB addresses, but the manual specifically
> >prohibits overlapping PMM ranges.
>
> And the code used for MontaVista's products has diverged somehow; it has
> an empty bios_fixup but code in a different place that does something
> different:
>
> /* plb address 0x8000 0000 will be set to pci address 0x8000 0000
> which
> corresponds to PCI 9030 Dev 0x10 BAR4 */
> out_le32((void*)PMM1LA,0x80000000);
> out_le32((void*)PMM1MA,0xFFFE0001); /* PLB range is 128KB */
> out_le32((void*)PMM1PCILA,0x80000000);
> out_le32((void*)PMM1PCIHA,0x00000000);
Well, it may be in a different place, but it looks like it has the
same problem. It is still establishing a PCI window at PLB address
0x80000000, which is the same address used for the PMM0 window - or is
that also different in the MV kernel?
> I'll try to figure out the story on this, but everything NP4GS3-related
> seems to be murky... NP4GS3 will probably need a custom bios_fixup that
> does the above (among other things), can worry about that platform later.
I'd be trying to work out what that mapping's actually for, first. I
still can't see how it can possibly work - if there are overlapping
PMM windows, what actually happens to accesses in that (PLB) range?
> >>This code is fragile and tends to break on certain platforms in ways
> >>that can't be explained by the available documentation. I can help test
> >>the unified version on Walnut/Sycamore/Ash if needed.
> >
> >
> >Do you mean the existing code, or my proposed patch (or both). That
> >would be great if you could test the code on those machines - I don't
> >have a Sycamore or Ash, and I'd have to drag the Walnut out again to
> >test on it.
>
> Yes, I can test your proposed code on those machines.
--
David Gibson | For every complex problem there is a
david@gibson•dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-10-09 2:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-27 12:27 very minor 405GP and 405GPr PCI difference Ralph Blach
2002-09-30 4:01 ` David Gibson
2002-10-01 5:21 ` David Gibson
2002-10-01 8:37 ` "David Müller (ELSOFT AG)"
2002-10-02 1:42 ` David Gibson
2002-10-02 4:26 ` Allen Curtis
2002-10-02 5:34 ` David Gibson
2002-10-02 17:03 ` Matt Porter
2002-10-03 1:10 ` David Gibson
2002-10-03 15:14 ` Matt Porter
2002-10-04 2:48 ` David Gibson
2002-10-04 18:33 ` Todd Poynor
2002-10-08 4:17 ` David Gibson
2002-10-08 19:39 ` Todd Poynor
2002-10-09 2:14 ` David Gibson [this message]
[not found] ` <20021 <20021023040850.GC1198@zax>
2002-10-24 23:50 ` Ralph Blach
2002-10-25 1:19 ` David Gibson
2002-10-02 7:46 ` "David Müller (ELSOFT AG)"
2002-10-03 1:12 ` David Gibson
2002-10-03 8:28 ` "David Müller (ELSOFT AG)"
2002-10-06 5:23 ` Andrew May
2002-10-07 1:31 ` Matt Porter
2002-10-08 4:14 ` David Gibson
2002-10-08 5:21 ` Andrew May
2002-10-08 14:56 ` Matt Porter
2002-10-08 17:31 ` Andrew May
2002-10-08 18:20 ` Matt Porter
2002-10-09 1:58 ` David Gibson
2002-10-09 10:35 ` Kenneth Johansson
2002-10-09 15:21 ` Allen Curtis
2002-10-11 19:37 ` Andrew May
2002-10-14 1:20 ` David Gibson
2002-10-08 6:19 ` Allen Curtis
2002-10-08 15:18 ` Matt Porter
2002-10-09 2:10 ` David Gibson
2002-10-22 21:55 ` Todd Poynor
2002-10-23 4:08 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2002-10-23 13:10 Ralph Blach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021009021403.GQ32555@zax \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=tpoynor@mvista$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox