From: Tom Rini <trini@kernel•crashing.org>
To: Joakim Tjernlund <Joakim.Tjernlund@lumentis•se>
Cc: linuxppc-embedded@lists•linuxppc.org, scop@digitel•com.br,
thomas@corelatus•com
Subject: Re: [PATCH] arch/ppc/8xx_io/enet.c, version 2
Date: Thu, 24 Oct 2002 07:59:31 -0700 [thread overview]
Message-ID: <20021024145931.GI669@opus.bloom.county> (raw)
In-Reply-To: <200210241423.g9OENV4d024137@blooper.utfors.se>
On Thu, Oct 24, 2002 at 04:23:31PM +0200, Joakim Tjernlund wrote:
> This is the second version of my patch that removes the expensive memcpy of
> received
> ethernet frames in interrupt context.
>
> I have 1 report(from Ricardo Scop) of 20% increase in packets/second, packet
> size 1500 when
> applied to 8260 FEC(needs to be applied manually). But min packet size
> decreased with 10 %.
> This version should fix the 10% decrease case.
>
> This patch could be adapted 8xx_io/fec.c and 8260_io/enet.c and
> 8260/fcc_enet.c with little effort.
>
> Better fix a bug in set_multicast_list(), move the dmi list forward when
> walking it(dmi = dmi->next;)
>
> New stuff:
> - Configrable: copy small packets or pass them directly, see
> COPY_SMALL_FRAMES in code.
> - Collision reporting fix form Thomas Lange.
> - Don't pass receive frames which has error upwards.
> - Report RX_OV errors as fifo errors, not crc errors.
>
> Please test and report any problems and performace improvements.
All of this sounds good, but can you please break this one patch up into
seperate logical patches?
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-10-24 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-24 14:23 [PATCH] arch/ppc/8xx_io/enet.c, version 2 Joakim Tjernlund
2002-10-24 14:59 ` Tom Rini [this message]
2002-10-24 15:46 ` Joakim Tjernlund
2002-11-01 11:01 ` Joakim Tjernlund
2003-01-28 11:54 ` [PATCH] arch/ppc/8xx_io/enet.c, version 3 Joakim Tjernlund
2003-02-03 10:21 ` Joakim Tjernlund
2003-02-03 12:28 ` Pantelis Antoniou
2002-10-28 15:17 ` [PATCH] arch/ppc/8xx_io/enet.c, version 2 Stephan Linke
2002-10-28 17:24 ` Joakim Tjernlund
2002-11-13 13:50 ` Hans Feldt
2002-11-13 16:35 ` Joakim Tjernlund
2002-11-13 19:30 ` Hans Feldt
2002-11-13 21:19 ` Joakim Tjernlund
2002-11-13 22:12 ` Dan Malek
2002-11-13 22:54 ` Joakim Tjernlund
2002-11-15 11:52 ` Hans Feldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021024145931.GI669@opus.bloom.county \
--to=trini@kernel$(echo .)crashing.org \
--cc=Joakim.Tjernlund@lumentis$(echo .)se \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=scop@digitel$(echo .)com.br \
--cc=thomas@corelatus$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox