From: Tom Rini <trini@kernel•crashing.org>
To: Wolfgang Denk <wd@denx•de>
Cc: linuxppc-embedded@lists•linuxppc.org
Subject: Re: linuxppc_2_4_devel patch: 8xx FEC extensions
Date: Mon, 23 Dec 2002 08:12:54 -0700 [thread overview]
Message-ID: <20021223151254.GC15397@opus.bloom.county> (raw)
In-Reply-To: <20021220010507.E88B6C613A@atlas.denx.de>
On Fri, Dec 20, 2002 at 02:05:07AM +0100, Wolfgang Denk wrote:
> It makes the following modifications to the MPC8xx FEC driver:
>
> - change PHY configuration from #define to kernel config mechanism
> - add support for AMD79C874 PHY
Both of these look OK, but can you please split this out into a seperate
patch which just does PHY configuration and then adds AMD79C874 support?
> - add multicast support
Sounds fine, but can you split this portion of the code from the rest of
the patch please? Thanks.
> - add PACKETHOOK support
This was removed, intentionally back on March 22nd, 2002. From what I
recall, it was decided this code was broken / unmaintained and should be
yanked. Have you tested this particular section of code to verify it
still compiles and works as expected?
In sum: On hold for now.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-12-23 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 1:05 linuxppc_2_4_devel patch: 8xx FEC extensions Wolfgang Denk
2002-12-23 15:12 ` Tom Rini [this message]
2002-12-28 0:27 ` Wolfgang Denk
2002-12-30 15:29 ` Tom Rini
2002-12-30 16:26 ` Wolfgang Denk
2002-12-30 18:12 ` Tom Rini
[not found] ` <3E10EF1C.5040505@embeddededge.com>
[not found] ` <20021231155241.GA12063@opus.bloom.county>
[not found] ` <20021231155839.6D6F8C6139@atlas.denx.de>
2002-12-31 16:13 ` Tom Rini
2003-01-02 17:40 ` Wolfgang Denk
[not found] ` <3E1480E6.4010802@embeddededge.com>
2003-01-02 18:21 ` Tom Rini
[not found] ` <3E1484D9.6070402@embeddededge.com>
2003-01-03 15:47 ` Tom Rini
2003-01-02 17:40 ` Dan Malek
2003-01-03 22:46 ` Paul Mackerras
2003-01-03 23:01 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021223151254.GC15397@opus.bloom.county \
--to=trini@kernel$(echo .)crashing.org \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=wd@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox