Subject: Re: linuxppc_2_4_devel patch: 8xx FEC extensions

From: Tom Rini <[email-masked]>
Date: Mon, 30 Dec 2002 11:12:58 -0700

On Mon, Dec 30, 2002 at 05:26:16PM +0100, Wolfgang Denk wrote:
> In message <[email-masked]> you wrote:
> >
> > scripts/Lindent is 'happy', then that's good enough.  Also, is there any
> > reason to go from 'volatile uint *s = &(...->...);' to 'uint s =
> > ...->...;' ?  Maybe it's too early in the morning for me, but why
> > couldn't it be just 'uint *s', if that volatile isn't needed?
[snip a good explanation]

Sounds reasonable.

> > This is on hold for now, and for future patches please keep cleanup
> > seperate from functionality as much as possible.
>
> This _is_ functionality.

It is not part of the multicast functionality, it's either an unrelated
but none the less important bug fix, or like other parts of the patch
just 'cleanup'.  So please in the future submit them as a seperate
logical chunk, since that's how I have to submit them.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/