From: Anton Blanchard <anton@samba•org>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Tom Rini <trini@kernel•crashing.org>,
Linux/PPC Development <linuxppc-dev@lists•linuxppc.org>
Subject: Re: PPC32: Add support for the OpenPIC register set to be in BE mode.
Date: Tue, 6 Jan 2004 02:28:30 +1100 [thread overview]
Message-ID: <20040105152830.GJ12213@krispykreme> (raw)
In-Reply-To: <Pine.GSO.4.58.0401051501220.3740@waterleaf.sonytel.be>
> > diff -Nru a/arch/ppc/kernel/open_pic.c b/arch/ppc/kernel/open_pic.c
> > --- a/arch/ppc/kernel/open_pic.c Sat Jan 3 12:02:04 2004
> > +++ b/arch/ppc/kernel/open_pic.c Sat Jan 3 12:02:04 2004
> > @@ -166,13 +166,21 @@
> > {
> > u_int val;
> >
> > +#ifdef CONFIG_PPC_OPENPIC_BE
> > + val = in_be32(addr);
> > +#else
> > val = in_le32(addr);
> > +#endif
> > return val;
> > }
>
> Wouldn't it be better to #define openpic_in() and openpic_out() macros, so you
> need the #ifdef at one spot only?
Or grab the bit out of the ppc64 openpic code that detects this at runtime
and get rid of the CONFIG option completely :)
Anton
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-01-05 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200401032002.i03K23iM024298@hera.kernel.org>
2004-01-05 14:02 ` PPC32: Add support for the OpenPIC register set to be in BE mode Geert Uytterhoeven
2004-01-05 15:28 ` Anton Blanchard [this message]
2004-01-05 15:41 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040105152830.GJ12213@krispykreme \
--to=anton@samba$(echo .)org \
--cc=geert@linux-m68k$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox