Subject: Re: [PATCH] PRxK sub-architecture

From: Marcelo Tosatti <[email-masked]>
Date: Fri, 15 Oct 2004 13:55:38 -0300

On Fri, Oct 15, 2004 at 11:15:39AM -0700, Tom Rini wrote:
> [ Switched over to linuxppc-embedded ]
> 
> On Fri, Oct 15, 2004 at 01:09:41PM -0300, Marcelo Tosatti wrote:
> 
> Just some rough comments:
> 
> [snip]
> > diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/8xx_io/fec.c linux-2.6-bkppc/arch/ppc/8xx_io/fec.c
> > --- linux-2.6-bkppc.orig/arch/ppc/8xx_io/fec.c	2004-09-02 08:52:19.000000000 -0300
> > +++ linux-2.6-bkppc/arch/ppc/8xx_io/fec.c	2004-09-02 14:33:23.000000000 -0300
> > @@ -173,7 +173,7 @@
> >  	uint	phy_status;
> >  	uint	phy_speed;
> >  	phy_info_t	*phy;
> > -	struct tq_struct phy_task;
> > +	struct work_struct phy_task;
> >  
> >  	uint	sequence_done;
> >  
> 
> This looks like a dupe of what's already in linuxppc-2.5.
> 
> [snip]
> > diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/boot/simple/embed_config.c linux-2.6-bkppc/arch/ppc/boot/simple/embed_config.c
> > --- linux-2.6-bkppc.orig/arch/ppc/boot/simple/embed_config.c	2004-09-02 08:52:19.000000000 -0300
> > +++ linux-2.6-bkppc/arch/ppc/boot/simple/embed_config.c	2004-09-02 10:17:19.000000000 -0300
> 
> This looks like it should be done in prxk.c, with the various hooks that
> we provide in misc.c, which might have to be ported to misc-embedded.c.

OK, I'll look into this.

> [snip]
> > diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/boot/simple/head.S linux-2.6-bkppc/arch/ppc/boot/simple/head.S
> > --- linux-2.6-bkppc.orig/arch/ppc/boot/simple/head.S	2004-09-02 08:52:19.000000000 -0300
> > +++ linux-2.6-bkppc/arch/ppc/boot/simple/head.S	2004-09-02 17:30:39.000000000 -0300
> 
> Do we really need to do this?  If so, why?

Yes because the bootloader jumps to 0x00002120. 

We can't afford to change that, I think.

I'll take a closer look at this too.

> [snip]
> > diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/include/asm-ppc/prxk.h linux-2.6-bkppc/include/asm-ppc/prxk.h
> > --- linux-2.6-bkppc.orig/include/asm-ppc/prxk.h	1969-12-31 21:00:00.000000000 -0300
> > +++ linux-2.6-bkppc/include/asm-ppc/prxk.h	2004-09-02 08:54:51.000000000 -0300
> [snip]
> > +/* Machine type
> > +*/
> > +#define _MACH_8xx (_MACH_PRxK)
> 
> Eh?  Is there more to come that moves 8xx towards what we have on
> pmac/prep/chrp ?  Or a left-over from older kernels?

I think its just a leftover from older kernels.

> Thanks.

Thank you for commenting!

I'll move embed_config() to prxk.c as suggested, fix the _bcopy_str(), 
and come up with another patch next week.