From: Gabriel Paubert <paubert@iram•es>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: TEST: Sleep suppport for iBook G4 & Aluminium PowerBooks (ATI based)
Date: Fri, 19 Nov 2004 12:06:09 +0100 [thread overview]
Message-ID: <20041119110609.GA2924@iram.es> (raw)
In-Reply-To: <1100847411.25521.42.camel@gaston>
On Fri, Nov 19, 2004 at 05:56:50PM +1100, Benjamin Herrenschmidt wrote:
> NOTE: Owners of _OTHER_ Apple laptops that could already sleep, like
> earlier iBooks, or Titanium PowerBooks, please test this patch as well
> for regression. More specifically, test if sleep still works, X/DRI, and
> backlight control as I have made significant changes to radeonfb in ways
> that could affect those areas.
Everytime my Pismo wakes up I have the following:
Badness in enable_irq at kernel/irq/manage.c:106
Call trace:
[c0006db4] dump_stack+0x18/0x28
[c0004dfc] check_bug_trap+0x84/0xac
[c0004f84] ProgramCheckException+0x160/0x1a0
[c00044e0] ret_from_except_full+0x0/0x4c
[c002f8dc] enable_irq+0xa0/0xa8
[c0205570] ohci_pci_resume+0xe4/0xfc
[c01fc018] usb_hcd_pci_resume+0xb0/0x114
[c013a9f0] pci_device_resume+0x4c/0x50
[c0181474] resume_device+0x44/0x4c
[c01815ac] dpm_resume+0x130/0x148
[c01815fc] device_resume+0x38/0x78
[c0424ac8] 0xc0424ac8
[c0424fb0] 0xc0424fb0
[c042581c] 0xc042581c
[c0064680] sys_ioctl+0xdc/0x2f4
Badness in enable_irq at kernel/irq/manage.c:106
Call trace:
[c0006db4] dump_stack+0x18/0x28
[c0004dfc] check_bug_trap+0x84/0xac
[c0004f84] ProgramCheckException+0x160/0x1a0
[c00044e0] ret_from_except_full+0x0/0x4c
[c002f8dc] enable_irq+0xa0/0xa8
[c0205570] ohci_pci_resume+0xe4/0xfc
[c01fc018] usb_hcd_pci_resume+0xb0/0x114
[c013a9f0] pci_device_resume+0x4c/0x50
[c0181474] resume_device+0x44/0x4c
[c01815ac] dpm_resume+0x130/0x148
[c01815fc] device_resume+0x38/0x78
[c0424ac8] 0xc0424ac8
[c0424fb0] 0xc0424fb0
[c042581c] 0xc042581c
[c0064680] sys_ioctl+0xdc/0x2f4
It happens when reenabling USB interrupts (before the recent
irq consolidation it was a one line message about unbalanced
irq_enable IIRC). The appended patch fixes the problem for my
machine, the explanation being that some higher level code now
does an explicit free_irq() before suspending and request_irq()
on resume (in drivers/usb/core/hcd-pci.c).
Gabriel
===== drivers/usb/host/ohci-pci.c 1.33 vs edited =====
--- 1.33/drivers/usb/host/ohci-pci.c 2004-11-07 23:31:07 +01:00
+++ edited/drivers/usb/host/ohci-pci.c 2004-11-19 11:55:10 +01:00
@@ -119,14 +119,11 @@
/* let things settle down a bit */
msleep (100);
-
-#ifdef CONFIG_PMAC_PBOOK
- if (_machine == _MACH_Pmac)
- disable_irq ((to_pci_dev(hcd->self.controller))->irq);
+#ifdef CONFIG_PMAC_PBOOK
{
- struct device_node *of_node;
-
+ struct device_node *of_node;
+
/* Disable USB PAD & cell clock */
of_node = pci_device_to_OF_node (to_pci_dev(hcd->self.controller));
if (of_node)
@@ -164,13 +161,6 @@
retval = ohci_hub_resume (hcd);
usb_unlock_device (hcd->self.root_hub);
#endif
-
- if (retval == 0) {
-#ifdef CONFIG_PMAC_PBOOK
- if (_machine == _MACH_Pmac)
- enable_irq (to_pci_dev(hcd->self.controller)->irq);
-#endif
- }
return retval;
}
next prev parent reply other threads:[~2004-11-19 11:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 6:56 TEST: Sleep suppport for iBook G4 & Aluminium PowerBooks (ATI based) Benjamin Herrenschmidt
2004-11-19 8:50 ` David Woodhouse
2004-11-19 10:33 ` Benjamin Herrenschmidt
2004-11-19 11:06 ` Gabriel Paubert [this message]
2004-11-19 22:14 ` Benjamin Herrenschmidt
2004-11-19 19:02 ` Olof Johansson
[not found] ` <1100852423.3855.2.camel@gaston>
2004-11-21 0:01 ` Benjamin Herrenschmidt
2004-11-21 3:00 ` Armando Di Cianno
2004-11-21 7:11 ` Benjamin Herrenschmidt
2004-11-21 17:37 ` Olof Johansson
2004-11-21 21:36 ` Benjamin Herrenschmidt
2004-11-22 8:25 ` David Woodhouse
2004-11-22 0:32 ` TEST: Sleep patch #4 Benjamin Herrenschmidt
2004-11-22 3:12 ` Armando Di Cianno
2004-11-22 13:29 ` Sean Neakums
2004-11-22 16:38 ` Keith Conger
2004-11-22 16:58 ` Keith Conger
2004-11-22 21:48 ` Benjamin Herrenschmidt
2004-11-22 18:36 ` Sean Neakums
2004-11-22 21:52 ` Benjamin Herrenschmidt
2004-11-23 8:27 ` Sean Neakums
2004-11-23 23:25 ` Benjamin Herrenschmidt
2004-11-23 7:58 ` Guido Guenther
2004-11-23 8:40 ` Sean Neakums
2004-11-22 21:13 ` Michel Dänzer
2004-11-22 21:48 ` Benjamin Herrenschmidt
2004-11-22 17:04 ` Michael Schmitz
2004-11-22 21:50 ` Benjamin Herrenschmidt
2004-11-23 8:05 ` Michael Schmitz
2004-11-23 12:28 ` Michael Schmitz
2004-11-23 23:27 ` Benjamin Herrenschmidt
2004-11-23 1:40 ` Chris Anderson
-- strict thread matches above, loose matches on Subject: below --
2004-11-19 22:10 TEST: Sleep suppport for iBook G4 & Aluminium PowerBooks (ATI based) Benjamin Herrenschmidt
2004-11-20 21:47 Sean Neakums
2004-11-20 22:08 ` Armando Di Cianno
2004-11-20 22:20 ` Michel Dänzer
2004-11-20 22:22 ` Benjamin Herrenschmidt
2004-11-20 22:31 ` Armando Di Cianno
2004-11-20 22:41 ` Sean Neakums
2004-11-20 22:44 ` Sean Neakums
2004-11-20 22:52 ` Benjamin Herrenschmidt
2004-11-20 23:01 ` Sean Neakums
2004-11-20 23:25 ` Sean Neakums
2004-11-21 19:34 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119110609.GA2924@iram.es \
--to=paubert@iram$(echo .)es \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox